From: Daniel Vetter <daniel@ffwll.ch>
To: Rodrigo Vivi <rodrigo.vivi@gmail.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] uxa: Do not change DPMS mode on unconnected outputs
Date: Mon, 23 Sep 2013 11:37:34 +0200 [thread overview]
Message-ID: <20130923093734.GB32145@phenom.ffwll.local> (raw)
In-Reply-To: <1379674600-23138-1-git-send-email-rodrigo.vivi@gmail.com>
On Fri, Sep 20, 2013 at 07:56:40AM -0300, Rodrigo Vivi wrote:
> "The operation is in theory redundant, and in the case of Haswell where
> we have multiple outputs aliasing to the same encoder, actually harmful."
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=68030
> Credits-to: Chris Wilson <chris@chris-wilson.co.uk>
> Tested-by: Rodrigo Vivi <rodrigo.vivi@gmail.com>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@gmail.com>
Can we have a testcase for this since this very much looks like a kernel
bug, specifically in intel_connector_dpms?
I think doing a dpms off on all connectors but the one we've just enabled
in kms_flip and then trying to do a few flips to check whether the pipe is
still on should be good enough.
Thanks, Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
prev parent reply other threads:[~2013-09-23 9:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-20 10:56 [PATCH] uxa: Do not change DPMS mode on unconnected outputs Rodrigo Vivi
2013-09-23 9:37 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130923093734.GB32145@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=rodrigo.vivi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.