From: Joel Becker <jlbec@evilplan.org>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH] ocfs2: fix possible double free in ocfs2_write_begin_nolock
Date: Thu, 7 Nov 2013 03:11:53 -0800 [thread overview]
Message-ID: <20131107111152.GF24799@localhost> (raw)
In-Reply-To: <526B86E0.9080009@huawei.com>
On Sat, Oct 26, 2013 at 05:09:52PM +0800, Xue jiufei wrote:
> When ocfs2_write_cluster_by_desc() failed in ocfs2_write_begin_nolock()
> because of ENOSPC, it goes to out_quota, freeing data_ac(meta_ac). Then
> it calls ocfs2_try_to_free_truncate_log() to free space. If enough
> space freed, it will try to write again. Unfortunately, some error
> happenes before ocfs2_lock_allocators(), it goes to out and free
> data_ac(meta_ac) again.
>
> Signed-off-by: joyce <xuejiufei@huawei.com>
Good catch. This function could use some refactoring for
understandability.
Acked-by: Joel Becker <jlbec@evilplan.org>
> ---
> fs/ocfs2/aops.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/fs/ocfs2/aops.c b/fs/ocfs2/aops.c
> index f37d3c0..8ad0a41 100644
> --- a/fs/ocfs2/aops.c
> +++ b/fs/ocfs2/aops.c
> @@ -1897,10 +1897,14 @@ out_commit:
> out:
> ocfs2_free_write_ctxt(wc);
>
> - if (data_ac)
> + if (data_ac) {
> ocfs2_free_alloc_context(data_ac);
> - if (meta_ac)
> + data_ac = NULL;
> + }
> + if (meta_ac) {
> ocfs2_free_alloc_context(meta_ac);
> + meta_ac = NULL;
> + }
>
> if (ret == -ENOSPC && try_free) {
> /*
> --
> 1.7.9.7
>
>
> _______________________________________________
> Ocfs2-devel mailing list
> Ocfs2-devel at oss.oracle.com
> https://oss.oracle.com/mailman/listinfo/ocfs2-devel
--
Life's Little Instruction Book #464
"Don't miss the magic of the moment by focusing on what's
to come."
http://www.jlbec.org/
jlbec at evilplan.org
prev parent reply other threads:[~2013-11-07 11:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-26 9:09 [Ocfs2-devel] [PATCH] ocfs2: fix possible double free in ocfs2_write_begin_nolock Xue jiufei
2013-10-26 9:58 ` Jeff Liu
2013-11-07 11:11 ` Joel Becker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131107111152.GF24799@localhost \
--to=jlbec@evilplan.org \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.