From: Vinod Koul <vinod.koul@intel.com>
To: Olof Johansson <olof@lixom.net>
Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dmaengine: ipu: fix warnings from 64-bit dma_addr_t printouts
Date: Wed, 13 Nov 2013 13:54:44 +0530 [thread overview]
Message-ID: <20131113082444.GQ8834@intel.com> (raw)
In-Reply-To: <1384324244-11330-1-git-send-email-olof@lixom.net>
On Tue, Nov 12, 2013 at 10:30:43PM -0800, Olof Johansson wrote:
> This resolves a number of warnings such as the below when building with
> 64-bit dma_addr_t on arm:
>
> drivers/dma/ipu/ipu_idmac.c:1235:2: warning: format '%x' expects argument
> of type 'unsigned int', but argument 5 has type 'dma_addr_t' [-Wformat=]
>
> ..by upcasting to u64 and using %llx.
Applied both
Thanks
~Vinod
>
> Signed-off-by: Olof Johansson <olof@lixom.net>
> ---
> drivers/dma/ipu/ipu_idmac.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/dma/ipu/ipu_idmac.c b/drivers/dma/ipu/ipu_idmac.c
> index cb9c0bc..128ca14 100644
> --- a/drivers/dma/ipu/ipu_idmac.c
> +++ b/drivers/dma/ipu/ipu_idmac.c
> @@ -1232,8 +1232,10 @@ static irqreturn_t idmac_interrupt(int irq, void *dev_id)
> desc = list_entry(ichan->queue.next, struct idmac_tx_desc, list);
> descnew = desc;
>
> - dev_dbg(dev, "IDMAC irq %d, dma 0x%08x, next dma 0x%08x, current %d, curbuf 0x%08x\n",
> - irq, sg_dma_address(*sg), sgnext ? sg_dma_address(sgnext) : 0, ichan->active_buffer, curbuf);
> + dev_dbg(dev, "IDMAC irq %d, dma %#llx, next dma %#llx, current %d, curbuf %#x\n",
> + irq, (u64)sg_dma_address(*sg),
> + sgnext ? (u64)sg_dma_address(sgnext) : 0,
> + ichan->active_buffer, curbuf);
>
> /* Find the descriptor of sgnext */
> sgnew = idmac_sg_next(ichan, &descnew, *sg);
> --
> 1.7.10.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe dmaengine" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
prev parent reply other threads:[~2013-11-13 9:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-13 6:30 [PATCH 1/2] dmaengine: ipu: fix warnings from 64-bit dma_addr_t printouts Olof Johansson
2013-11-13 6:30 ` [PATCH 2/2] dma: imx-sdma: Fix warnings for LPAE builds Olof Johansson
2013-11-13 8:24 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131113082444.GQ8834@intel.com \
--to=vinod.koul@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olof@lixom.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.