From: Mark Fasheh <mfasheh@suse.de>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH] ocfs2: drop the unwanted null byte in dentry lock name
Date: Thu, 28 Nov 2013 08:40:44 -0800 [thread overview]
Message-ID: <20131128164044.GB29346@wotan.suse.de> (raw)
In-Reply-To: <20131127153841.4d3414a425d735459288f4ee@linux-foundation.org>
On Wed, Nov 27, 2013 at 03:38:41PM -0800, Andrew Morton wrote:
> On Wed, 27 Nov 2013 17:05:00 +0800 Joseph Qi <joseph.qi@huawei.com> wrote:
>
> > Dentry lock name is made up of the type 'N', the parent blkno and its
> > blkno represented as a binary value.
> > Now there is a null byte between parent blkno and the binary blkno
> > value, so drop it.
>
> Geeze.
>
> What are the runtime effects of this change?
This will change the over-the-wire protocol, so big NACK for this
patch please. Some of the lock names are binary and have been forever now.
We have a limited amount of space in the name and some lock types would have
names too long if we stringified every field.
--Mark
--
Mark Fasheh
next prev parent reply other threads:[~2013-11-28 16:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-27 9:05 [Ocfs2-devel] [PATCH] ocfs2: drop the unwanted null byte in dentry lock name Joseph Qi
2013-11-27 23:38 ` Andrew Morton
2013-11-28 1:03 ` Joseph Qi
2013-11-28 16:40 ` Mark Fasheh [this message]
2013-11-30 1:45 ` Joseph Qi
2013-12-01 23:16 ` Mark Fasheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131128164044.GB29346@wotan.suse.de \
--to=mfasheh@suse.de \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.