From: Julien Grall <julien@xen.org>
To: Michal Orzel <michal.orzel@amd.com>, xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
Bertrand Marquis <bertrand.marquis@arm.com>,
Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH 1/3] xen/arm64: head: Move earlyprintk 'hex' string to .rodata.str
Date: Tue, 21 Nov 2023 17:04:55 +0000 [thread overview]
Message-ID: <20135dd2-d36e-4c83-bdb6-b987174f18f2@xen.org> (raw)
In-Reply-To: <5b4ac8af-98a6-4757-9946-d520baa6a2a7@amd.com>
On 21/11/2023 17:00, Michal Orzel wrote:
> Hi Julien,
Hi,
> On 21/11/2023 17:09, Julien Grall wrote:
>>
>>
>> Hi Michal,
>>
>> On 21/11/2023 09:45, Michal Orzel wrote:
>>> At the moment, the 'hex' string is placed right after the 'putn'
>>> function in the .text section. This is because of the limited range
>>> (+/- 1MB) of PC relative 'adr' instruction 'putn' uses. Modify it to use
>>> 'adr_l' instead (range extended to +/- 4GB) and move the string to
>>> .rodata.str. This way all the earlyprintk messages will be part of .rodata
>>> and the behavior will be consistent with what we already do on arm32.
>>
>> This will be correct today, but I am actually thinking to move 'hex' to
>> .rodata.idmap so it can be used while we are on the 1:1 mapping and/or
>> temporary mapping.
> So you are planning on extending your series to also cover arm64?
It is not in my soonish plan. But you are arguing that this patch is for
consistency with arm32. This will not be after my series.
And I would not change arm64 just for consistency because I don't view
it as necessary. The boot code is already not the same.
Cheers,
--
Julien Grall
next prev parent reply other threads:[~2023-11-21 17:05 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-21 9:45 [PATCH 0/3] xen/arm64: head: misc cleanup Michal Orzel
2023-11-21 9:45 ` [PATCH 1/3] xen/arm64: head: Move earlyprintk 'hex' string to .rodata.str Michal Orzel
2023-11-21 15:48 ` Luca Fancellu
2023-11-21 16:09 ` Julien Grall
2023-11-21 17:00 ` Michal Orzel
2023-11-21 17:04 ` Julien Grall [this message]
2023-11-21 17:18 ` Michal Orzel
2023-11-21 18:31 ` Julien Grall
2023-11-22 7:54 ` Michal Orzel
2023-11-21 9:45 ` [PATCH 2/3] xen/arm64: Move print_reg macro to asm/arm64/macros.h Michal Orzel
2023-11-21 16:05 ` Luca Fancellu
2023-11-21 16:16 ` Julien Grall
2023-11-21 17:02 ` Michal Orzel
2023-11-21 9:45 ` [PATCH 3/3] xen/arm64/mmu: head: Replace load_paddr with adr_l where appropriate Michal Orzel
2023-11-21 16:30 ` Julien Grall
2023-11-21 18:13 ` Michal Orzel
2023-11-21 18:43 ` Julien Grall
2023-11-22 8:12 ` Michal Orzel
2023-11-21 16:31 ` Luca Fancellu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20135dd2-d36e-4c83-bdb6-b987174f18f2@xen.org \
--to=julien@xen.org \
--cc=Volodymyr_Babchuk@epam.com \
--cc=bertrand.marquis@arm.com \
--cc=michal.orzel@amd.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.