From: Bjorn Helgaas <bhelgaas@google.com>
To: Stephen Hemminger <stephen@networkplumber.org>,
linux-pci@vger.kernel.org
Cc: Yu Zhao <yu.zhao@intel.com>
Subject: [PATCH v2 09/12] PCI: Remove unused alloc_pci_dev()
Date: Fri, 10 Jan 2014 18:27:50 -0700 [thread overview]
Message-ID: <20140111012749.14505.39904.stgit@bhelgaas-glaptop.roam.corp.google.com> (raw)
In-Reply-To: <20140111012339.14505.40203.stgit@bhelgaas-glaptop.roam.corp.google.com>
From: Stephen Hemminger <stephen@networkplumber.org>
My philosophy is unused code is dead code. And dead code is subject to bit
rot and is a likely source of bugs. Use it or lose it.
This removes this unused and deprecated interface:
alloc_pci_dev()
[bhelgaas: split to separate patch]
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
---
drivers/pci/probe.c | 6 ------
include/linux/pci.h | 1 -
2 files changed, 7 deletions(-)
diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c
index 38e403dddf6e..a4f53b677185 100644
--- a/drivers/pci/probe.c
+++ b/drivers/pci/probe.c
@@ -1242,12 +1242,6 @@ struct pci_dev *pci_alloc_dev(struct pci_bus *bus)
}
EXPORT_SYMBOL(pci_alloc_dev);
-struct pci_dev *alloc_pci_dev(void)
-{
- return pci_alloc_dev(NULL);
-}
-EXPORT_SYMBOL(alloc_pci_dev);
-
bool pci_bus_read_dev_vendor_id(struct pci_bus *bus, int devfn, u32 *l,
int crs_timeout)
{
diff --git a/include/linux/pci.h b/include/linux/pci.h
index 9d860912dd88..da76c757d0ac 100644
--- a/include/linux/pci.h
+++ b/include/linux/pci.h
@@ -375,7 +375,6 @@ static inline struct pci_dev *pci_physfn(struct pci_dev *dev)
}
struct pci_dev *pci_alloc_dev(struct pci_bus *bus);
-struct pci_dev * __deprecated alloc_pci_dev(void);
#define to_pci_dev(n) container_of(n, struct pci_dev, dev)
#define for_each_pci_dev(d) while ((d = pci_get_device(PCI_ANY_ID, PCI_ANY_ID, d)) != NULL)
next prev parent reply other threads:[~2014-01-11 1:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-11 1:26 [PATCH v2 00/12] Remove dead code Bjorn Helgaas
2014-01-11 1:26 ` [PATCH v2 01/12] PCI: Removed unused parts of Page Request Interface support Bjorn Helgaas
2014-01-11 1:26 ` [PATCH v2 02/12] PCI: Remove unused Latency Tolerance Reporting support Bjorn Helgaas
2014-01-11 1:27 ` [PATCH v2 03/12] PCI: Remove unused Optimized Buffer Flush/Fill support Bjorn Helgaas
2014-01-11 1:27 ` [PATCH v2 04/12] PCI: Remove unused ID-Based Ordering support Bjorn Helgaas
2014-01-11 1:27 ` [PATCH v2 05/12] PCI: Remove unused exclusive region support Bjorn Helgaas
2014-01-13 18:12 ` Bjorn Helgaas
2014-01-11 1:27 ` [PATCH v2 06/12] PCI: Remove unused pci_vpd_truncate() Bjorn Helgaas
2014-01-11 1:27 ` [PATCH v2 07/12] PCI: Remove unused pcie_aspm_enabled() Bjorn Helgaas
2014-01-11 1:27 ` [PATCH v2 08/12] PCI: Remove unused pci_renumber_slot() Bjorn Helgaas
2014-01-13 18:43 ` Alex Chiang
2014-01-11 1:27 ` Bjorn Helgaas [this message]
2014-01-11 1:27 ` [PATCH v2 10/12] PCI: Make local functions static Bjorn Helgaas
2014-01-11 1:28 ` [PATCH v2 11/12] PCI: Reorder pci.h so actual interfaces come before stubs Bjorn Helgaas
2014-01-11 1:28 ` [PATCH v2 12/12] PCI: Cleanup pci.h whitespace Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140111012749.14505.39904.stgit@bhelgaas-glaptop.roam.corp.google.com \
--to=bhelgaas@google.com \
--cc=linux-pci@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=yu.zhao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.