[PATCH] Fix select-induced Kconfig warning for ZBOOT_ROM

From: thierry.reding@gmail.com (Thierry Reding)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] Fix select-induced Kconfig warning for ZBOOT_ROM
Date: Mon, 13 Jan 2014 12:52:10 +0100	[thread overview]
Message-ID: <20140113115208.GA22313@ulmo.nvidia.com> (raw)
In-Reply-To: <3792319.Wf518ByjFs@wuerfel>

On Wed, Jan 08, 2014 at 09:20:10AM +0100, Arnd Bergmann wrote:
> On Wednesday 08 January 2014 13:32:35 Viresh Kumar wrote:
> > On Thu, Jan 2, 2014 at 9:53 PM, Russell King
> > <rmk+kernel@arm.linux.org.uk> wrote:
> > > warning: (ARCH_MULTIPLATFORM && ARCH_CLPS711X && ARCH_PXA &&
> > >  SOC_EXYNOS5440 && ARCH_EMEV2) selects AUTO_ZRELADDR which
> > >  has unmet direct dependencies (!ZBOOT_ROM)
> > >
> > > This is because it's possible to have ZBOOT_ROM enabled, but at the
> > > same time have another option enabled which selects AUTO_ZRELADDR
> > > overriding the !ZBOOT_ROM dependency.  Fix this by reversing the
> > > dependencies between ZBOOT_ROM and the options which depend on
> > > !ZBOOT_ROM.
> > >
> > > Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
> > > ---
> > 
> > After this patch I see these warnings with exynos_defconfig
> > 
> > arch/arm/Kconfig:1963:error: recursive dependency detected!
> > arch/arm/Kconfig:1963: symbol ZBOOT_ROM depends on AUTO_ZRELADDR
> > arch/arm/Kconfig:2151: symbol AUTO_ZRELADDR is selected by ZBOOT_ROM
> > 
> > I am not really sure why this happened as I don't see AUTO_ZRELADDR
> > selected by ZBOOT_ROM in Kconfig :)
> 
> It's a weird dependency. You need this hunk:
> 
> --- a/arch/arm/mach-imx/Kconfig
> +++ b/arch/arm/mach-imx/Kconfig
> @@ -3,7 +3,7 @@ config ARCH_MXC
>         select ARCH_REQUIRE_GPIOLIB
>         select ARM_CPU_SUSPEND if PM
>         select ARM_PATCH_PHYS_VIRT
> -       select AUTO_ZRELADDR if !ZBOOT_ROM
> +       select AUTO_ZRELADDR
>         select CLKSRC_MMIO
>         select COMMON_CLK
>         select GENERIC_ALLOCATOR

Hi Arnd,

I haven't seen this go into linux-next yet. Do you plan on sending a
patch for this?

Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140113/0a36b637/attachment.sig>