From: Chris Wilson <chris@chris-wilson.co.uk>
To: Ben Widawsky <ben@bwidawsk.net>
Cc: Intel GFX <intel-gfx@lists.freedesktop.org>,
Ben Widawsky <benjamin.widawsky@intel.com>
Subject: Re: [PATCH 5/5] drm/i915: Fix error capture on BYT/BDW
Date: Sun, 26 Jan 2014 19:55:59 +0000 [thread overview]
Message-ID: <20140126195559.GB5258@nuc-i3427.alporthouse.com> (raw)
In-Reply-To: <20140126190540.GE894@bwidawsk.net>
On Sun, Jan 26, 2014 at 11:05:40AM -0800, Ben Widawsky wrote:
> On Sun, Jan 26, 2014 at 11:47:40AM +0000, Chris Wilson wrote:
> > On Fri, Jan 24, 2014 at 06:17:45PM -0800, Ben Widawsky wrote:
> > > The previous check during error capture of whether or not the current VM
> > > should be scanned used, gen < 7. That was more or less trying to
> > > determine if there was a full PPGTT. At the time, this was sort of what
> > > I meant to do because I was more interested in working backwards from
> > > hardware state. However, this is incorrect because it will not include
> > > platforms that are greater than gen7, and not having PPGTT. Example
> > > would be BYT which is gen7 but doesn't have PPGTT, BDW, or any platform
> > > greater than gen7 with the PPGTT module parameter invoked.
> > >
> > > I am /assuming/ BYT was broken, I have not actually checked.
> > >
> > > While here, clean up the file a bit to avoid duplicate reads (now that
> > > the PPGTT info is in the error state).
> > >
> > > I think Mika/Chris may have been looking at this too.
> >
> > Sure, we are looking (for identifying the guilty request/batch) by using
> > the older, simpler mechanism of finding the first incomplete request. I
> > think that search is now definite since we preallocate the request and no
> > longer do request collascing if ENOMEM (i.e. there is a 1:1 relationship
> > between seqno/batch/request).
> >
> > That should also apply here and be much simpler.
>
> How does that solve hangs which aren't caused by requests?
Was that an intentional rhetorical question?
The code you touch here only deals with requests - finding the current
batchbuffer if any.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2014-01-26 19:56 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-25 2:17 [PATCH 1/5] drm/i915: Place the Global GTT VM first in the list of VM Ben Widawsky
2014-01-25 2:17 ` [PATCH 2/5] drm/i915: Print captured bo for all VM in error state Ben Widawsky
2014-01-25 2:17 ` [PATCH 3/5] drm/i915: Create a USES_PPGTT macro Ben Widawsky
2014-01-25 20:41 ` Daniel Vetter
2014-01-26 5:45 ` Ben Widawsky
2014-01-26 9:24 ` Daniel Vetter
2014-01-25 2:17 ` [PATCH 4/5] drm/i915: Capture PPGTT info on error capture Ben Widawsky
2014-01-26 11:42 ` Chris Wilson
2014-01-26 19:06 ` Ben Widawsky
2014-01-26 19:51 ` Chris Wilson
2014-01-25 2:17 ` [PATCH 5/5] drm/i915: Fix error capture on BYT/BDW Ben Widawsky
2014-01-26 11:47 ` Chris Wilson
2014-01-26 19:05 ` Ben Widawsky
2014-01-26 19:55 ` Chris Wilson [this message]
2014-01-26 21:47 ` Ben Widawsky
2014-01-27 13:45 ` Chris Wilson
2014-01-27 18:24 ` Ben Widawsky
2014-01-27 20:31 ` Ben Widawsky
2014-01-27 21:31 ` Chris Wilson
2014-01-27 21:54 ` Ben Widawsky
2014-01-25 8:32 ` [PATCH 1/5] drm/i915: Place the Global GTT VM first in the list of VM Kenneth Graunke
2014-01-25 20:48 ` Daniel Vetter
2014-01-25 21:31 ` Kenneth Graunke
2014-01-26 5:09 ` Ben Widawsky
2014-01-26 9:26 ` Daniel Vetter
2014-01-26 11:10 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140126195559.GB5258@nuc-i3427.alporthouse.com \
--to=chris@chris-wilson.co.uk \
--cc=ben@bwidawsk.net \
--cc=benjamin.widawsky@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.