From: Daniel Vetter <daniel@ffwll.ch>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>,
intel-gfx@lists.freedesktop.org, Ben Widawsky <ben@bwidawsk.net>,
stable@vger.kernel.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915: Decouple GPU error reporting from ring initialisation
Date: Mon, 27 Jan 2014 17:13:10 +0100 [thread overview]
Message-ID: <20140127161310.GC9772@phenom.ffwll.local> (raw)
In-Reply-To: <20140127140524.GT9454@intel.com>
On Mon, Jan 27, 2014 at 04:05:24PM +0200, Ville Syrjälä wrote:
> On Mon, Jan 27, 2014 at 01:52:34PM +0000, Chris Wilson wrote:
> > Currently we report through our error state only the rings that have
> > been initialised (as detected by ring->obj). This check is done after
> > the GPU reset and ring re-initialisation, which means that the software
> > state may not be the same as when we captured the hardware error and we
> > may not print out any of the vital information for debugging the hang.
> >
> > This (and the implied object leak) is a regression from
> >
> > commit 3d57e5bd1284f44e325f3a52d966259ed42f9e05
> > Author: Ben Widawsky <ben@bwidawsk.net>
> > Date: Mon Oct 14 10:01:36 2013 -0700
> >
> > drm/i915: Do a fuller init after reset
> >
> > Note that we are already starting to get bug reports with incomplete
> > error states from 3.13.
> >
> > v2: Prevent a NULL dereference on 830gm/845g after a GPU reset where
> > the scratch obj may be NULL.
> >
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Ben Widawsky <ben@bwidawsk.net>
> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > References: https://bugs.freedesktop.org/show_bug.cgi?id=74094
> > Cc: stable@vger.kernel.org
>
> Looks OK to me.
>
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Picked up for -fixes, thanks for the patch. I've also added a tag for the
stable team to fasttrack this one since it's a developer feature.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
prev parent reply other threads:[~2014-01-27 16:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-23 21:49 [PATCH] drm/i915: Decouple GPU error reporting from ring initialisation Chris Wilson
2014-01-24 11:50 ` Ville Syrjälä
2014-01-24 11:55 ` Chris Wilson
2014-01-24 12:06 ` Ville Syrjälä
2014-01-27 13:52 ` Chris Wilson
2014-01-27 14:05 ` Ville Syrjälä
2014-01-27 16:13 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140127161310.GC9772@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=ben@bwidawsk.net \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=stable@vger.kernel.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.