From: Daniel Vetter <daniel@ffwll.ch>
To: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v2 1/4] drm/i915: Use i915_hw_context to set reset stats
Date: Thu, 30 Jan 2014 16:26:08 +0100 [thread overview]
Message-ID: <20140130152608.GT17001@phenom.ffwll.local> (raw)
In-Reply-To: <1391090475-15814-1-git-send-email-mika.kuoppala@intel.com>
On Thu, Jan 30, 2014 at 04:01:15PM +0200, Mika Kuoppala wrote:
> With full ppgtt support drm_i915_file_private gained knowledge
> about the default context. Also reset stats are now inside
> i915_hw_context so we can use proper abstraction.
>
> v2: Move BUG_ON and WARN_ON to more proper locations (Ben)
>
> Suggested-by: Ben Widawsky <ben@bwidawsk.net>
> Signed-off-by: Mika Kuoppala <mika.kuoppala@intel.com>
> Reviewed-by: Ben Widawsky <ben@bwidawsk.net>
[snip]
> + BUG_ON(!ctx->last_ring);
I've changed this to a WARN_ON - killing the entire driver over this seems
a bit excessive.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2014-01-30 15:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-29 15:05 [PATCH 0/4] context reset stats fixes for ppgtt Mika Kuoppala
2014-01-29 15:05 ` [PATCH 1/4] drm/i915: Use i915_hw_context to set reset stats Mika Kuoppala
2014-01-29 20:38 ` Ben Widawsky
2014-01-30 14:01 ` [PATCH v2 " Mika Kuoppala
2014-01-30 15:26 ` Daniel Vetter [this message]
2014-01-29 15:05 ` [PATCH 2/4] drm/i915: Tune down debug output when context is banned Mika Kuoppala
2014-01-29 20:47 ` Ben Widawsky
2014-01-29 20:54 ` Daniel Vetter
2014-01-30 14:05 ` [PATCH v3 " Mika Kuoppala
2014-01-29 15:05 ` [PATCH 3/4] drm/i915: Use hangcheck score to find guilty context Mika Kuoppala
2014-01-29 15:05 ` [PATCH 4/4] drm/i915: Get rid of acthd based guilty batch search Mika Kuoppala
2014-01-29 21:44 ` Ben Widawsky
2014-01-30 12:59 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140130152608.GT17001@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=mika.kuoppala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.