All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thierry Reding <thierry.reding@gmail.com>
To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Cc: Mark Brown <broonie@kernel.org>,
	iivanov@mm-sol.com, gsi@denx.de, linux-spi@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] spi: core: make zero length transfer valid again
Date: Mon, 3 Mar 2014 09:26:58 +0100	[thread overview]
Message-ID: <20140303082657.GA3372@ulmo.nvidia.com> (raw)
In-Reply-To: <1393596196-8652-1-git-send-email-anemo@mba.ocn.ne.jp>

[-- Attachment #1: Type: text/plain, Size: 679 bytes --]

On Fri, Feb 28, 2014 at 11:03:16PM +0900, Atsushi Nemoto wrote:
> Zero length transfer becomes invalid since
> "spi: core: Validate length of the transfers in message" commit,
> but it should be valid to support an odd device, for example, which
> requires long delay between chipselect and the first transfer, etc.
> 
> Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
> ---
>  drivers/spi/spi.c |    5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)

This fixes a regression on Venice2, where the keyboard controller relied
on similar behaviour, so even if this is already applied,

Tested-by: Thierry Reding <treding@nvidia.com>

Thanks,
Thierry

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

      parent reply	other threads:[~2014-03-03  8:27 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-28 14:03 [PATCH] spi: core: make zero length transfer valid again Atsushi Nemoto
2014-02-28 14:03 ` Atsushi Nemoto
2014-03-01  4:13 ` Mark Brown
2014-03-01  4:13   ` Mark Brown
2014-03-01 11:40   ` Martin Sperl
2014-03-01 11:40     ` Martin Sperl
2014-03-03  1:05     ` Mark Brown
2014-03-03  1:05       ` Mark Brown
2014-03-03  8:26 ` Thierry Reding [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140303082657.GA3372@ulmo.nvidia.com \
    --to=thierry.reding@gmail.com \
    --cc=anemo@mba.ocn.ne.jp \
    --cc=broonie@kernel.org \
    --cc=gsi@denx.de \
    --cc=iivanov@mm-sol.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.