From: Mark Brown <broonie@kernel.org>
To: Jyri Sarha <jsarha@ti.com>
Cc: alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
linux-omap@vger.kernel.org, peter.ujfalusi@ti.com,
liam.r.girdwood@linux.intel.com, bcousson@baylibre.com,
detheridge@ti.com
Subject: Re: [PATCH v4] ASoC: tlv320aic31xx: Add basic codec driver implementation
Date: Mon, 10 Mar 2014 15:47:44 +0000 [thread overview]
Message-ID: <20140310154744.GJ28112@sirena.org.uk> (raw)
In-Reply-To: <531DBD55.6030008@ti.com>
[-- Attachment #1: Type: text/plain, Size: 1094 bytes --]
On Mon, Mar 10, 2014 at 03:25:41PM +0200, Jyri Sarha wrote:
> On 03/10/2014 02:58 PM, Mark Brown wrote:
> >On Mon, Mar 10, 2014 at 10:52:21AM +0200, Jyri Sarha wrote:
> >>>+- ai31xx-micbias-vg - MicBias Voltage setting
> >>>+ 0 or MICBIAS_OFF - MICBIAS output it not powered
> >So, on every other version of this patch set I've suggested removing
> >this as there's no reason why the bias would be wired up but disabled.
> >Each time you seem to agree that the option should be removed yet here
> >it is again...
> I agreed on not to have it as the default. I can still imagine
> couple of reason to have this option around. For instance, if the
> board designer decides to pull the bias voltage from outside of the
> chip completely, or like in my test setup when I feed the mic input
> from a headset output of another device, because I do not have a
> microphone around ATM.
To repeat what I said first time around in those cases the pin wouldn't
be connected at all so why would it ever be enabled? You're not
specifying that it's going to be always enabled at a given voltage.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-03-10 15:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-10 8:52 [PATCH v4] AM43xx-ePOS-EVM audio support with TLV320AIC31XX driver Jyri Sarha
2014-03-10 8:52 ` [PATCH v4] ASoC: tlv320aic31xx: Add basic codec driver implementation Jyri Sarha
2014-03-10 9:39 ` Lokesh Vutla
2014-03-10 9:45 ` Mark Brown
2014-03-10 12:09 ` Mark Rutland
2014-03-10 12:11 ` Mark Brown
2014-03-10 13:15 ` Jyri Sarha
2014-03-10 13:31 ` Mark Rutland
2014-03-10 12:58 ` Mark Brown
[not found] ` <20140310125848.GI28112-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2014-03-10 13:25 ` Jyri Sarha
2014-03-10 15:47 ` Mark Brown [this message]
2014-03-10 16:05 ` Jyri Sarha
2014-03-10 19:23 ` Jyri Sarha
2014-03-10 9:13 ` [PATCH v4] AM43xx-ePOS-EVM audio support with TLV320AIC31XX driver Mark Brown
2014-03-10 9:26 ` Jyri Sarha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140310154744.GJ28112@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bcousson@baylibre.com \
--cc=detheridge@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=jsarha@ti.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-omap@vger.kernel.org \
--cc=peter.ujfalusi@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.