From: Daniel Vetter <daniel@ffwll.ch>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Intel GFX <intel-gfx@lists.freedesktop.org>,
Mika Kuoppala <mika.kuoppala@intel.com>,
Ben Widawsky <ben@bwidawsk.net>,
Ben Widawsky <benjamin.widawsky@intel.com>
Subject: Re: [PATCH] drm/i915: Don't del_timer_sync uninitialized timer
Date: Mon, 17 Mar 2014 10:52:00 +0100 [thread overview]
Message-ID: <20140317095159.GR30571@phenom.ffwll.local> (raw)
In-Reply-To: <87a9cp191q.fsf@intel.com>
On Mon, Mar 17, 2014 at 11:14:25AM +0200, Jani Nikula wrote:
> On Mon, 17 Mar 2014, Jani Nikula <jani.nikula@linux.intel.com> wrote:
> > On Sat, 15 Mar 2014, Ben Widawsky <benjamin.widawsky@intel.com> wrote:
> >> Broken by:
> >> commit 0294ae7b44bba7ab0d4cef9a8736287f38bdb4fd
> >> Author: Chris Wilson <chris@chris-wilson.co.uk>
> >> Date: Thu Mar 13 12:00:29 2014 +0000
> >>
> >> drm/i915: Consolidate forcewake resetting to a single function
> >>
> >
> > Does this result in https://bugs.freedesktop.org/show_bug.cgi?id=76242 ?
>
> QA confirms this patch fixes the bug.
Also the commit message seriously lacks details. Apparantly this only
blows up with lockdep (since most my machines here are still happy), which
is a rather crucial detail.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
prev parent reply other threads:[~2014-03-17 9:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-15 0:21 [PATCH] drm/i915: Don't del_timer_sync uninitialized timer Ben Widawsky
2014-03-15 8:22 ` Chris Wilson
2014-03-15 11:47 ` Daniel Vetter
2014-03-15 15:20 ` Chris Wilson
2014-03-15 18:30 ` Ben Widawsky
2014-03-15 19:13 ` Daniel Vetter
2014-03-17 13:17 ` Chris Wilson
2014-03-17 13:52 ` Daniel Vetter
2014-03-17 7:56 ` Jani Nikula
2014-03-17 9:14 ` Jani Nikula
2014-03-17 9:52 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140317095159.GR30571@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=ben@bwidawsk.net \
--cc=benjamin.widawsky@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=mika.kuoppala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.