All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Wilson <chris@chris-wilson.co.uk>
To: Michel Lespinasse <walken@google.com>
Cc: Andrea Arcangeli <aarcange@redhat.com>,
	Rik van Riel <riel@redhat.com>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	intel-gfx@lists.freedesktop.org,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 1/3] lib: Export interval_tree
Date: Tue, 18 Mar 2014 09:56:12 +0000	[thread overview]
Message-ID: <20140318095612.GM18530@nuc-i3427.alporthouse.com> (raw)
In-Reply-To: <CANN689GuFPOujE=1KTXpgTnyDbChX9WDnfBLk+jYK_h4d=VjYQ@mail.gmail.com>

On Mon, Mar 17, 2014 at 06:08:57AM -0700, Michel Lespinasse wrote:
> On Mon, Mar 17, 2014 at 5:31 AM, David Woodhouse <dwmw2@infradead.org> wrote:
> > On Mon, 2014-03-17 at 12:21 +0000, Chris Wilson wrote:
> >> +EXPORT_SYMBOL(interval_tree_insert);
> >> +EXPORT_SYMBOL(interval_tree_remove);
> >> +EXPORT_SYMBOL(interval_tree_iter_first);
> >> +EXPORT_SYMBOL(interval_tree_iter_next);
> >
> > I'd prefer to see EXPORT_SYMBOL_GPL for this.
> 
> I'm fine with it either way. I think it would help if you stated the
> reason for your preference though ?

Nobody objects?

How about

v3: Prefer EXPORT_SYMBOL_GPL for new library routines

as the reason in the changelog for amending the patch?
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre

  reply	other threads:[~2014-03-18  9:56 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-17 12:21 [PATCH 1/3] lib: Export interval_tree Chris Wilson
2014-03-17 12:21 ` [PATCH 2/3] drm/i915: Do not call retire_requests from wait_for_rendering Chris Wilson
2014-03-28 22:58   ` Volkin, Bradley D
2014-04-17 22:20     ` Volkin, Bradley D
2014-04-24  9:22     ` Chris Wilson
2014-04-24 16:20       ` Volkin, Bradley D
2014-04-25 14:18         ` Daniel Vetter
2014-03-17 12:21 ` [PATCH 3/3] drm/i915: Introduce mapping of user pages into video memory (userptr) ioctl Chris Wilson
2014-04-17 22:18   ` Volkin, Bradley D
2014-05-16 10:07     ` Chris Wilson
2014-03-17 12:31 ` [PATCH 1/3] lib: Export interval_tree David Woodhouse
2014-03-17 13:08   ` Michel Lespinasse
2014-03-18  9:56     ` Chris Wilson [this message]
2014-04-25 14:17       ` Daniel Vetter
  -- strict thread matches above, loose matches on Subject: below --
2014-02-21 18:45 Chris Wilson
2014-01-28 10:34 New API for creating bo from user pages Chris Wilson
2014-01-28 10:34 ` [PATCH 1/3] lib: Export interval_tree Chris Wilson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140318095612.GM18530@nuc-i3427.alporthouse.com \
    --to=chris@chris-wilson.co.uk \
    --cc=a.p.zijlstra@chello.nl \
    --cc=aarcange@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=riel@redhat.com \
    --cc=walken@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.