From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Ben Widawsky <ben@bwidawsk.net>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm/i915: Print how many objects are shared in per-process statsg
Date: Thu, 20 Mar 2014 15:11:22 +0100 [thread overview]
Message-ID: <20140320141122.GO30571@phenom.ffwll.local> (raw)
In-Reply-To: <20140320074037.GL4890@nuc-i3427.alporthouse.com>
On Thu, Mar 20, 2014 at 07:40:37AM +0000, Chris Wilson wrote:
> On Wed, Mar 19, 2014 at 09:42:49PM -0700, Ben Widawsky wrote:
> > On Wed, Mar 19, 2014 at 01:45:46PM +0000, Chris Wilson wrote:
> > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> >
> > Any clue how you intend to use this for a commit message (I'm actually
> > curious)? Also, the subject is wrong, you're counting size, not
> > quantity. Anyhoo, looks correct.
>
> Knowing how much of the allocated objects are shared between processes
> helps gauge whether a process is leaking private objects, or if it
> simply a display server suffering memory pressure from lots of clients.
I've added something along these lines here.
>
> > Reviewed-by: Ben Widawsky <ben@bwidawsk.net>
Both patches merged, thanks.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2014-03-20 14:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-13 14:57 [PATCH 3/4] drm/i915: Per-process stats work better when evaluated per-process Rodrigo Vivi
2014-03-19 0:05 ` Ben Widawsky
2014-03-19 6:55 ` Chris Wilson
2014-03-19 13:45 ` [PATCH 1/2] " Chris Wilson
2014-03-19 13:45 ` [PATCH 2/2] drm/i915: Print how many objects are shared in per-process stats Chris Wilson
2014-03-20 4:42 ` [PATCH 2/2] drm/i915: Print how many objects are shared in per-process statsg Ben Widawsky
2014-03-20 7:40 ` Chris Wilson
2014-03-20 14:11 ` Daniel Vetter [this message]
2014-03-19 17:30 ` [PATCH 1/2] drm/i915: Per-process stats work better when evaluated per-process Ben Widawsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140320141122.GO30571@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=ben@bwidawsk.net \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.