From: Daniel Vetter <daniel@ffwll.ch>
To: Ben Widawsky <ben@bwidawsk.net>
Cc: intel-gfx@lists.freedesktop.org,
Rob Bradford <robert.bradford@intel.com>
Subject: Re: [PATCH] prime_mmap: Add new test for calling mmap() on dma-buf fds
Date: Thu, 20 Mar 2014 16:08:29 +0100 [thread overview]
Message-ID: <20140320150829.GP30571@phenom.ffwll.local> (raw)
In-Reply-To: <20140320043135.GA1748@bwidawsk.net>
On Wed, Mar 19, 2014 at 09:31:35PM -0700, Ben Widawsky wrote:
> On Mon, Mar 17, 2014 at 07:43:35PM +0000, Rob Bradford wrote:
[snip]
> lgtm. Put the commit message in the test description and call it
> Reviewed-by: Ben Widawsky <ben@bwidawsk.net>
igt_assert_cmpint is a useful one, especially for checking failures ;-)
But yeah, lgtm too please push.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
prev parent reply other threads:[~2014-03-20 15:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-17 19:43 [PATCH] prime_mmap: Add new test for calling mmap() on dma-buf fds Rob Bradford
2014-03-20 4:31 ` Ben Widawsky
2014-03-20 15:08 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140320150829.GP30571@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=ben@bwidawsk.net \
--cc=intel-gfx@lists.freedesktop.org \
--cc=robert.bradford@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.