From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>,
intel-gfx@lists.freedesktop.org,
Jesse Barnes <jbarnes@virtuousgeek.org>
Subject: Re: [PATCH] drm/i915: Fix the computation of required fb size for pipe
Date: Wed, 2 Apr 2014 09:10:44 +0200 [thread overview]
Message-ID: <20140402071044.GI7225@phenom.ffwll.local> (raw)
In-Reply-To: <20140402065818.GM7314@nuc-i3427.alporthouse.com>
On Wed, Apr 02, 2014 at 07:58:18AM +0100, Chris Wilson wrote:
> On Thu, Mar 20, 2014 at 03:11:21PM +0000, Chris Wilson wrote:
> > The computation of required framebuffer size in
> >
> > commit d978ef14456a38034f6c0e94a794129501f89200
> > Author: Jesse Barnes <jbarnes@virtuousgeek.org>
> > Date: Fri Mar 7 08:57:51 2014 -0800
> >
> > drm/i915: Wrap the preallocated BIOS framebuffer and preserve for KMS fbcon v12
> >
> > is too optimistic, and would rely on the invariant fb being
> > reconstructed to exactly fit each pipe (and probably ignore hardware
> > limits). Instead, we want to compute the upper bound on what the display
> > engine will access and ensure that is within the inherited framebuffer.
> >
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Jesse Barnes <jbarnes@virtuousgeek.org>
>
> Ping. The code is just waiting to explode.
I kinda hoped it would magically get reviewed by Jesse. Thanks for the
ping, patch is picked up for -fixes.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2014-04-02 7:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-20 15:11 [PATCH] drm/i915: Fix the computation of required fb size for pipe Chris Wilson
2014-04-02 6:58 ` Chris Wilson
2014-04-02 7:10 ` Daniel Vetter [this message]
2014-04-02 15:03 ` Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140402071044.GI7225@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jbarnes@virtuousgeek.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.