Re: [PATCH] drm/mm: Don't WARN if drm_mm_reserve_node

From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Dave Airlie <airlied@redhat.com>,
	Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
	DRI Development <dri-devel@lists.freedesktop.org>,
	Ben Widawsky <benjamin.widawsky@intel.com>
Subject: Re: [PATCH] drm/mm: Don't WARN if drm_mm_reserve_node
Date: Mon, 7 Apr 2014 22:13:13 -0700	[thread overview]
Message-ID: <20140407221313.3c65dd3a@jbarnes-t420> (raw)
In-Reply-To: <1396905920-30049-1-git-send-email-daniel.vetter@ffwll.ch>

On Mon,  7 Apr 2014 23:25:20 +0200
Daniel Vetter <daniel.vetter@ffwll.ch> wrote:

> Jesse's BIOS fb reconstruction code actually relies on the -ENOSPC
> return value to detect overlapping framebuffers (which the bios uses
> always when lighting up more than one screen). All this fanciness
> happens in intel_alloc_plane_obj in intel_display.c.
> 
> Since no one else uses this we can savely remove the WARN without
> repercursions.
> 
> Reported-by: Ben Widawsky <benjamin.widawsky@intel.com>
> Cc: Ben Widawsky <benjamin.widawsky@intel.com>
> Cc: Jesse Barnes <jbarnes@virtuousgeek.org>
> Cc: Dave Airlie <airlied@redhat.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
>  drivers/gpu/drm/drm_mm.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/drm_mm.c b/drivers/gpu/drm/drm_mm.c
> index a2d45b748f86..e4dfd5c3b15e 100644
> --- a/drivers/gpu/drm/drm_mm.c
> +++ b/drivers/gpu/drm/drm_mm.c
> @@ -192,8 +192,6 @@ int drm_mm_reserve_node(struct drm_mm *mm, struct drm_mm_node *node)
>  		return 0;
>  	}
>  
> -	WARN(1, "no hole found for node 0x%lx + 0x%lx\n",
> -	     node->start, node->size);
>  	return -ENOSPC;
>  }
>  EXPORT_SYMBOL(drm_mm_reserve_node);

Yeah thanks, pushing this has been on my list for weeks now...