From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: Hans de Goede <hdegoede@redhat.com>,
Benjamin Tissoires <btissoir@redhat.com>,
Peter Hutterer <peter.hutterer@redhat.com>,
linux-input@vger.kernel.org
Subject: Re: [PATCH resend 2/2] input/serio/8042: Add firmware_id support
Date: Wed, 9 Apr 2014 13:09:23 -0700 [thread overview]
Message-ID: <20140409200923.GA25808@core.coreip.homeip.net> (raw)
In-Reply-To: <20140409182926.GB3196@srcf.ucam.org>
On Wed, Apr 09, 2014 at 07:29:26PM +0100, Matthew Garrett wrote:
> On Wed, Apr 09, 2014 at 11:24:34AM -0700, Dmitry Torokhov wrote:
>
> > Do we need all IDs? I'd expect we only interested in HID, not CIDs?
>
> I think HID handles the cases we've seen so far, but we could imagine a
> system vendor providing their own HID, a trackpad vendor's CID and then
> the generic mouse CID. It seems better to err on the side of including
> them.
OK, fair enough. Another question - do we want to prefix IDs with "PNP:"
prefix so that if we add device tree in the future we'll know what kind
of IDs we are dealing with?
--
Dmitry
next prev parent reply other threads:[~2014-04-09 20:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-09 8:47 [PATCH resend 0/2] input/serio: Add a firmware_id sysfs attribute Hans de Goede
2014-04-09 8:47 ` [PATCH resend 1/2] " Hans de Goede
2014-04-09 8:47 ` [PATCH resend 2/2] input/serio/8042: Add firmware_id support Hans de Goede
2014-04-09 18:24 ` Dmitry Torokhov
2014-04-09 18:29 ` Matthew Garrett
2014-04-09 20:09 ` Dmitry Torokhov [this message]
2014-04-10 9:02 ` Hans de Goede
2014-04-13 8:23 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140409200923.GA25808@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=btissoir@redhat.com \
--cc=hdegoede@redhat.com \
--cc=linux-input@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=peter.hutterer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.