Re: [PATCH RFC V2 4/4] tools: virtio: add a top-like utility for displaying vhost satistics

From: Fam Zheng <famz@redhat.com>
To: Jason Wang <jasowang@redhat.com>
Cc: virtio-dev@lists.oasis-open.org, kvm@vger.kernel.org,
	mst@redhat.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	virtualization@lists.linux-foundation.org
Subject: Re: [PATCH RFC V2 4/4] tools: virtio: add a top-like utility for displaying vhost satistics
Date: Thu, 10 Apr 2014 17:27:02 +0800	[thread overview]
Message-ID: <20140410092702.GJ22890__19772.7644736462$1397138630$gmane$org@T430.nay.redhat.com> (raw)
In-Reply-To: <1395394913-19548-5-git-send-email-jasowang@redhat.com>

On Fri, 03/21 17:41, Jason Wang wrote:
> This patch adds simple python to display vhost satistics of vhost, the codes
> were based on kvm_stat script from qemu. As work function has been recored,
> filters could be used to distinguish which kinds of work are being executed or
> queued:
> 
> vhost statistics
> 
>  vhost_virtio_update_used_idx               1215215       0
>  vhost_virtio_get_vq_desc                   1215215       0
>  vhost_work_queue_wakeup                     986808       0
>  vhost_virtio_signal                         811601       0
>  vhost_net_tx                                611457       0
>  vhost_net_rx                                603758       0
>  vhost_net_tx(datacopy)                      601903       0
>  vhost_work_queue_wakeup(rx_net)             565081       0
>  vhost_virtio_signal(rx)                     461603       0
>  vhost_work_queue_wakeup(tx_kick)            421718       0
>  vhost_virtio_update_avail_event             417346       0
>  vhost_virtio_signal(tx)                     349998       0
>  vhost_work_queue_coalesce                    39384       0
>  vhost_work_queue_coalesce(rx_net)            38677       0
>  vhost_net_tx(zerocopy)                        9554       0
>  vhost_work_queue_coalesce(tx_kick)             707       0
>  vhost_work_queue_wakeup(rx_kick)                 9       0
> 
> Signed-off-by: Jason Wang <jasowang@redhat.com>
> ---
>  tools/virtio/vhost_stat | 375 ++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 375 insertions(+)
>  create mode 100755 tools/virtio/vhost_stat
> 
> diff --git a/tools/virtio/vhost_stat b/tools/virtio/vhost_stat
> new file mode 100755
> index 0000000..398fd4a
> --- /dev/null
> +++ b/tools/virtio/vhost_stat
> @@ -0,0 +1,375 @@
> +#!/usr/bin/python
> +#
> +# top-like utility for displaying vhost statistics
> +#
> +# Copyright 2012 Red Hat, Inc.

Should it be 2014?

Fam

<snip>