From: David Sterba <dsterba@suse.cz>
To: Brendan Hide <brendan@swiftspirit.co.za>
Cc: Chris Mason <clm@fb.com>,
linux-btrfs@vger.kernel.org, Miao Xie <miaox@cn.fujitsu.com>,
Wang Shilong <wangsl.fnst@cn.fujitsu.com>
Subject: Re: [PATCH 1/2] btrfs: protect snapshots from deleting during send
Date: Wed, 16 Apr 2014 17:22:39 +0200 [thread overview]
Message-ID: <20140416152239.GB29256@suse.cz> (raw)
In-Reply-To: <534E9ABD.4060300@swiftspirit.co.za>
On Wed, Apr 16, 2014 at 04:59:09PM +0200, Brendan Hide wrote:
> On 2014/04/16 03:40 PM, Chris Mason wrote:
> >So in my example with the automated tool, the tool really shouldn't be
> >deleting a snapshot where send is in progress. The tool should be told
> >that snapshot is busy and try to delete it again later.
> >
> >It makes more sense now, 'll queue this up for 3.16 and we can try it out
> >in -next.
> >
> >-chris
> So ... does this mean the plan is to a) have userland tool give an error; or
> b) a deletion would be "scheduled" in the background for as soon as the send
> has completed?
b) is current state, a) is the plan
with the patch, 'btrfs subvol delete' would return EPERM/EBUSY
next prev parent reply other threads:[~2014-04-16 15:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-15 14:41 [PATCH 0/2] Snapshot deletion vs send (for 3.15) David Sterba
2014-04-15 14:41 ` [PATCH 1/2] btrfs: protect snapshots from deleting during send David Sterba
2014-04-15 14:52 ` Chris Mason
2014-04-15 15:44 ` David Sterba
2014-04-15 16:00 ` Chris Mason
2014-04-15 16:27 ` David Sterba
2014-04-15 17:21 ` Chris Mason
2014-04-16 13:32 ` David Sterba
2014-04-16 13:40 ` Chris Mason
2014-04-16 14:59 ` Brendan Hide
2014-04-16 15:22 ` David Sterba [this message]
2014-04-26 12:16 ` Brendan Hide
2014-04-16 15:18 ` David Sterba
2014-05-12 13:52 ` Chris Mason
2014-04-15 14:42 ` [PATCH 2/2] btrfs: assert that send is not in progres before root deletion David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140416152239.GB29256@suse.cz \
--to=dsterba@suse.cz \
--cc=brendan@swiftspirit.co.za \
--cc=clm@fb.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=miaox@cn.fujitsu.com \
--cc=wangsl.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.