From: Mark Brown <broonie@kernel.org>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: daniel@zonque.org, alsa-devel@alsa-project.org,
Liam Girdwood <lgirdwood@gmail.com>, Jyri Sarha <jsarha@ti.com>
Subject: Re: [PATCH 3/3] ASoC: davinci-mcasp: Optimize pm_runtime usage and clean up the init code
Date: Tue, 22 Apr 2014 12:47:12 +0100 [thread overview]
Message-ID: <20140422114712.GO12304@sirena.org.uk> (raw)
In-Reply-To: <1398164594-29169-4-git-send-email-peter.ujfalusi@ti.com>
[-- Attachment #1.1: Type: text/plain, Size: 539 bytes --]
On Tue, Apr 22, 2014 at 02:03:14PM +0300, Peter Ujfalusi wrote:
> Move the pm_runtime_enable/disable to dai driver probe/remove callbacks from
> module probe/remove callbacks.
> With this change we can remove the platform driver's remove function since
> it became NULL.
This does mean that if the device gets enumerated but isn't used in the
system it won't go to runtime idle since the DAI level probe is only
called when we're building a card. That doesn't seem like it's a win.
How about creating a devm_pm_runtime_enable() instead?
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2014-04-22 11:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-22 11:03 [PATCH 0/3] ASoC: davinci: devm_snd_soc_register_platform and mcasp cleanup Peter Ujfalusi
2014-04-22 11:03 ` [PATCH 1/3] ASoC: davinci-pcm: Convert to use devm_snd_soc_register_platform() Peter Ujfalusi
2014-04-22 11:51 ` Mark Brown
2014-04-22 11:03 ` [PATCH 2/3] ASoC: davinci-mcasp: Convert to use devm_snd_soc_register_component() Peter Ujfalusi
2014-04-22 11:51 ` Mark Brown
2014-04-22 11:03 ` [PATCH 3/3] ASoC: davinci-mcasp: Optimize pm_runtime usage and clean up the init code Peter Ujfalusi
2014-04-22 11:47 ` Mark Brown [this message]
2014-04-22 12:20 ` Peter Ujfalusi
2014-04-22 18:52 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140422114712.GO12304@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=daniel@zonque.org \
--cc=jsarha@ti.com \
--cc=lgirdwood@gmail.com \
--cc=peter.ujfalusi@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.