From: Josh Cartwright <joshc@codeaurora.org>
To: "Ivan T. Ivanov" <iivanov@mm-sol.com>
Cc: Courtney Cavin <courtney.cavin@sonymobile.com>,
Josh Cartwright <joshc@codeaurora.org>,
Rob Herring <robherring2@gmail.com>,
Samuel Ortiz <sameo@linux.intel.com>,
Lee Jones <lee.jones@linaro.org>,
linux-kernel@vger.kernel.org,
linux-arm-msm <linux-arm-msm@vger.kernel.org>
Subject: Re: [RFC PATCH] mfd: pm8x41: Naive function devices registration
Date: Fri, 25 Apr 2014 09:15:51 -0500 [thread overview]
Message-ID: <20140425141551.GL5546@joshc.qualcomm.com> (raw)
In-Reply-To: <1398429171-8566-1-git-send-email-iivanov@mm-sol.com>
On Fri, Apr 25, 2014 at 03:32:51PM +0300, Ivan T. Ivanov wrote:
> From: "Ivan T. Ivanov" <iivanov@mm-sol.com>
>
> Currently functions that exist in both the controller at the
> same address offset can not be specified with the same names.
The terminology here is a bit confusing. When I read "controller", I
hear "SPMI controller", but this is really not a limitation of the SPMI
core, but rather a limitation of of_platform_populate() used by this
particular SPMI slave MFD driver.
> Adding Unique Slave ID device address to prefix function
> device names fixes this.
>
> Function devices are SPMI devices, so register them on
> SPMI bus.
This is a step backwards. The PMIC functions are not individually
addressable SPMI slaves, and as such should not be represented as
independent devices to the SPMI core.
They really are subfunctions of a particular SPMI slave, and should be
modeled as children of that slave device. With this driver, we've
chosen to model the child devices as platform devices, but it could
also be a separate bus type.
Josh
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
next prev parent reply other threads:[~2014-04-25 14:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-25 12:32 [RFC PATCH] mfd: pm8x41: Naive function devices registration Ivan T. Ivanov
2014-04-25 13:00 ` Rob Herring
2014-04-25 13:29 ` Ivan T. Ivanov
2014-04-25 13:43 ` Rob Herring
2014-04-25 14:15 ` Ivan T. Ivanov
2014-04-25 14:15 ` Josh Cartwright [this message]
2014-04-25 14:34 ` Ivan T. Ivanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140425141551.GL5546@joshc.qualcomm.com \
--to=joshc@codeaurora.org \
--cc=courtney.cavin@sonymobile.com \
--cc=iivanov@mm-sol.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robherring2@gmail.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.