All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Michal Marek <mmarek@suse.cz>
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
	David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH 1/5] firmware: Simplify directory creation
Date: Wed, 30 Apr 2014 18:12:04 +0200	[thread overview]
Message-ID: <20140430161204.GA15320@ravnborg.org> (raw)
In-Reply-To: <1398780493-15391-2-git-send-email-mmarek@suse.cz>

On Tue, Apr 29, 2014 at 04:08:09PM +0200, Michal Marek wrote:
> When building the firmware blobs, use a simple loop to create
> directories in $(objtree), like in Makefile.build. This simplifies the
> rules and also makes it possible to set $(objtree) to '.' later. Before
> this change, a dependency on $(objtree)/<dir> would be satisfied by
> <dir> in $(srctree).
> 
> When installing the firmware blobs, call mkdir like in Makefile.modinst.
> 
> Cc: David Woodhouse <dwmw2@infradead.org>
> Signed-off-by: Michal Marek <mmarek@suse.cz>

Hi Michal.

The patch looks good. I di not stare enough to fully grasp it,
but it is a nice cleanup.

	Sam

  reply	other threads:[~2014-04-30 16:12 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-29 14:08 [PATCH 0/5] kbuild: Use relative paths if possible Michal Marek
2014-04-29 14:08 ` [PATCH 1/5] firmware: Simplify directory creation Michal Marek
2014-04-30 16:12   ` Sam Ravnborg [this message]
2014-05-05 14:52     ` Michal Marek
2014-04-29 14:08 ` [PATCH 2/5] firmware: Use $(quote) in the Makefile Michal Marek
2014-04-29 14:08 ` [PATCH 3/5] kbuild: Use relative path for $(objtree) Michal Marek
2014-04-29 14:08 ` [PATCH 4/5] kbuild: Use relative path when building in the source tree Michal Marek
2014-04-29 14:08 ` [PATCH 5/5] kbuild: Use relative path when building in a subdir of " Michal Marek
2014-04-30 16:13 ` [PATCH 0/5] kbuild: Use relative paths if possible Sam Ravnborg
2014-05-05 14:52   ` Michal Marek
2014-05-08 20:44   ` Michal Marek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140430161204.GA15320@ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=dwmw2@infradead.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mmarek@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.