Re: [PATCH v2 1/2] ASoC: Add driver for CLPS711X DAI interface

From: Mark Brown <broonie@kernel.org>
To: Alexander Shiyan <shc_work@mail.ru>
Cc: alsa-devel@alsa-project.org, Arnd Bergmann <arnd@arndb.de>,
	Takashi Iwai <tiwai@suse.de>, Liam Girdwood <lgirdwood@gmail.com>,
	Olof Johansson <olof@lixom.net>
Subject: Re: [PATCH v2 1/2] ASoC: Add driver for CLPS711X DAI interface
Date: Thu, 1 May 2014 12:01:02 -0700	[thread overview]
Message-ID: <20140501190102.GW3245@sirena.org.uk> (raw)
In-Reply-To: <1398970472.345896645@f415.i.mail.ru>

[-- Attachment #1.1: Type: text/plain, Size: 1059 bytes --]

On Thu, May 01, 2014 at 10:54:32PM +0400, Alexander Shiyan wrote:
> Thu, 1 May 2014 11:29:35 -0700 от Mark Brown <broonie@kernel.org>:

> > This machinery seems pretty much identical to the FIQ code for i.MX -
> > I know you don't think anything can be shared but can you please be more
> > explicit about why?  The contents of the FIQ are different but the
> > start and stop mechanics don't look so different (and given that the
> > general idea of what they do is very similar this isn't surprising to
> > me).

> That is, you really want to make some common code for this?

Well, I'd like to understand why we're not doing common code in more
detail - it's pretty fiddly and detailed stuff to be cut'n'pasting.  On
the other hand if it looks horrible to do that then perhaps that's
actually the best way to go.  Either factor it out or give a bit more
detail on why that's not the way forwards.

> OK, I will review this again, but where do you think it should be located?

A file in sound/soc (soc-pcm-fiq.c or something) perhaps?

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]