Re: [PATCH v2 0/2] render state initialization (bdw rc6)

From: Damien Lespiau <damien.lespiau@intel.com>
To: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org, miku@iki.fi, ben@bwidawsk.net,
	kristen@linux.intel.com
Subject: Re: [PATCH v2 0/2] render state initialization (bdw rc6)
Date: Wed, 14 May 2014 11:08:09 +0100	[thread overview]
Message-ID: <20140514100809.GC1486@strange.amr.corp.intel.com> (raw)
In-Reply-To: <1399382766-25116-1-git-send-email-mika.kuoppala@intel.com>

On Tue, May 06, 2014 at 04:26:04PM +0300, Mika Kuoppala wrote:
> Hi,
> 
> V2 series of the render state initialization patches.
> 
> I decided not to pursue the copying of the context object as the ctx
> is quite big, atleast on bdw. As discussed in irc, the copying
> could be done with blitter, on context creation time. But even then we would 
> need to wait for it to complete. Pushing 1kbytes of commands doesn't
> sound so bad when the alternative is to copy 18 pages.
> 
> The state generators can be found here but they are not needed for testing.
> http://cgit.freedesktop.org/~miku/intel-gpu-tools/log/?h=null_state_gen
> 
> Here is the branch for testing:
> http://cgit.freedesktop.org/~miku/drm-intel/log/?h=render_state
> 
> Thank you to all who provided feedback.
> -Mika
> 
> Mika Kuoppala (2):
>   drm/i915: add render state initialization
>   drm/i915: add null render states for gen6, gen7 and gen8

Acked-by: Damien Lespiau <damien.lespiau@intel.com>

> 
>  drivers/gpu/drm/i915/Makefile                 |    6 +
>  drivers/gpu/drm/i915/i915_drv.h               |    2 +
>  drivers/gpu/drm/i915/i915_gem_context.c       |    6 +
>  drivers/gpu/drm/i915/i915_gem_render_state.c  |  186 ++++++++++
>  drivers/gpu/drm/i915/intel_renderstate.h      |   48 +++
>  drivers/gpu/drm/i915/intel_renderstate_gen6.c |  289 +++++++++++++++
>  drivers/gpu/drm/i915/intel_renderstate_gen7.c |  253 +++++++++++++
>  drivers/gpu/drm/i915/intel_renderstate_gen8.c |  479 +++++++++++++++++++++++++
>  8 files changed, 1269 insertions(+)
>  create mode 100644 drivers/gpu/drm/i915/i915_gem_render_state.c
>  create mode 100644 drivers/gpu/drm/i915/intel_renderstate.h
>  create mode 100644 drivers/gpu/drm/i915/intel_renderstate_gen6.c
>  create mode 100644 drivers/gpu/drm/i915/intel_renderstate_gen7.c
>  create mode 100644 drivers/gpu/drm/i915/intel_renderstate_gen8.c
> 
> -- 
> 1.7.9.5
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx