All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Jacob Pan <jacob.jun.pan@linux.intel.com>
Cc: rafael.j.wysocki@intel.com, linux-kernel@vger.kernel.org,
	linux-pm@vger.kernel.org, lenb@kernel.org, mingo@kernel.org,
	tglx@linutronix.de, hpa@zytor.com, arjan@linux.intel.com,
	rui.zhang@intel.com, luto@amacapital.net
Subject: Re: [PATCH] idle, thermal, acpi: Remove home grown idle implementations
Date: Thu, 5 Jun 2014 08:55:20 +0200	[thread overview]
Message-ID: <20140605065520.GB3213@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <20140604015812.140a00d1@jacob-desktop>

[-- Attachment #1: Type: text/plain, Size: 1269 bytes --]

On Wed, Jun 04, 2014 at 01:58:12AM -0700, Jacob Pan wrote:
> On Wed, 4 Jun 2014 10:54:18 +0200
> Peter Zijlstra <peterz@infradead.org> wrote:
> 
> > 
> > I'm still sitting on this patch. Jacub you were going to make it play
> > nice with QoS?
> > 
> I had a patchset to work through system PM QOS and still maintain the
> idle injection efficiency. When I saw you did not merge the patch
> below, I thought you have abandoned it :)

I was waiting for you to do the QoS bits :-)

> The only issue as per our last discussion is the lack of notification
> when PM QOS cannot be met. But that is intrinsic to PM QOS itself.
> 
> I also consulted with Arjan and looked at directly intercept with
> intel_idle since both intel_powerclamp and intel_idle are arch specific
> drivers. But I think that is hard to do at per idle period basis,
> since we should still allow "natural" idle during the forced idle time.
> 
> So, I think we can take a two stepped approach,
> 1. integrate your patch with a
> updated version of https://lkml.org/lkml/2013/11/26/534 such that there
> is no performance/efficiency regression.
> 2. add notification mechanism to system qos when constraints cannot be
> met.

That's fine with me; can you respin those bits?

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

  parent reply	other threads:[~2014-06-05  6:55 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-04  8:54 [PATCH] idle, thermal, acpi: Remove home grown idle implementations Peter Zijlstra
2014-06-04  8:58 ` Jacob Pan
2014-06-04 21:34   ` Rafael J. Wysocki
2014-06-04 22:59     ` Jacob Pan
2014-06-05  7:12       ` Peter Zijlstra
2014-06-05  6:55   ` Peter Zijlstra [this message]
2014-06-06 15:47     ` Jacob Pan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140605065520.GB3213@twins.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=arjan@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=jacob.jun.pan@linux.intel.com \
    --cc=lenb@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=mingo@kernel.org \
    --cc=rafael.j.wysocki@intel.com \
    --cc=rui.zhang@intel.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.