From: Pavel Machek <pavel@ucw.cz>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Linux PM list <linux-pm@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Zhang Rui <rui.zhang@intel.com>
Subject: Re: [PATCH v2] PM / sleep: Rename symbols, functions and variables related to sleep
Date: Fri, 1 Aug 2014 22:20:01 +0200 [thread overview]
Message-ID: <20140801202001.GA13738@amd.pavel.ucw.cz> (raw)
In-Reply-To: <74048613.5iSL8BqdeO@vostro.rjw.lan>
On Fri 2014-08-01 16:33:12, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> The names of several symbols, data types, functions and variables
> related to system sleep states are confusing and don't reflect the
> real behavior of those states correctly.
>
> First of all, there generally are two sleep states that require
> platform support and one sleep state that is platform-independent.
> The first two of them are currently known as MEM and STANDBY,
> although these names really only match what the states do on full
> hardware ACPI compliant systems. MEM in particular is supposed
> to mean "suspend-to-RAM", but in fact it means "the deepest sleep
> state available with platform support". The definition of STANDBY
> is even more arbitrary.
>
> Moreover, the remaining sleep state that doesn't need platform support
> is currently called FREEZE, which leads to double confusion with the
> process freezer (used during transitions to all sleep states) and
> with the freeze stage of processing devices during hibernation.
>
> For these reasons, rename the PM_SUSPEND_MEM, PM_SUSPEND_STANDBY
> and PM_SUSPEND_FREEZE symbols to PM_SUSPEND_DEEP, PM_SUSPEND_SHALLOW
> and PM_IDLE_SLEEP, respectively, everywhere and rename data types,
> functions and variables related to those states to match the new names
> of the symbols.
>
> This is a semi-mechanical replacement of names and it should not lead
> to any functional differences.
>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Acked-by: Pavel Machek <pavel@ucw.cz>
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2014-08-01 20:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-27 23:13 [RFC][PATCH] PM / sleep: Rename symbols, functions and variables related to sleep Rafael J. Wysocki
2014-07-29 23:41 ` Rafael J. Wysocki
2014-07-30 6:15 ` Zhang Rui
2014-07-30 6:50 ` Pavel Machek
2014-08-01 13:56 ` Rafael J. Wysocki
2014-08-01 14:33 ` [PATCH v2] " Rafael J. Wysocki
2014-08-01 20:20 ` Pavel Machek [this message]
2014-08-11 15:15 ` [RFC][PATCH] " Olof Johansson
2014-08-12 1:19 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140801202001.GA13738@amd.pavel.ucw.cz \
--to=pavel@ucw.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.