From: Mark Brown <broonie@kernel.org>
To: Anatol Pomozov <anatol.pomozov@gmail.com>
Cc: oder_chiou@realtek.com, alsa-devel@alsa-project.org, lgirdwood@gmail.com
Subject: Re: [PATCH 1/2] ASoC: rt5677: Add a configuration option for LDO2_POW pin
Date: Wed, 17 Sep 2014 09:57:54 -0700 [thread overview]
Message-ID: <20140917165754.GN7960@sirena.org.uk> (raw)
In-Reply-To: <1410931739-6088-1-git-send-email-anatol.pomozov@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 576 bytes --]
On Tue, Sep 16, 2014 at 10:28:58PM -0700, Anatol Pomozov wrote:
> + if (gpio_is_valid(rt5677->pow_ldo2)) {
> + ret = devm_gpio_request_one(&i2c->dev, rt5677->pow_ldo2,
> + GPIOF_OUT_INIT_HIGH,
> + "RT5677 POW_LDO2");
> + if (ret < 0) {
> + dev_err(&i2c->dev, "Failed to request POW_LDO2 %d: %d\n",
> + rt5677->pow_ldo2, ret);
> + return ret;
> + }
> + msleep(10);
> + }
This doesn't disable the GPIO on remove which I'd expect, along with
management at at least suspend and resume if not at runtime. The
removal is the most important one though.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
prev parent reply other threads:[~2014-09-17 16:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-17 5:28 [PATCH 1/2] ASoC: rt5677: Add a configuration option for LDO2_POW pin Anatol Pomozov
2014-09-17 5:28 ` [PATCH 2/2] ASoC: rt5677: Add sidetone controls Anatol Pomozov
2014-09-17 16:58 ` Mark Brown
2014-09-17 16:57 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140917165754.GN7960@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=anatol.pomozov@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=oder_chiou@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.