From: Lee Jones <lee.jones@linaro.org>
To: Sebastian Reichel <sre@kernel.org>
Cc: Nishanth Menon <nm@ti.com>, Samuel Ortiz <sameo@linux.intel.com>,
Tony Lindgren <tony@atomide.com>,
linux-omap@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2 1/2] Documentation: devicetree: mfd: twl4030-power: Use the standard 'ti,system-power-controller' to mark power control
Date: Wed, 17 Sep 2014 14:39:58 -0700 [thread overview]
Message-ID: <20140917213958.GU30918@lee--X1> (raw)
In-Reply-To: <20140917165529.GA24699@earth.universe>
On Wed, 17 Sep 2014, Sebastian Reichel wrote:
> On Wed, Sep 17, 2014 at 08:44:00AM -0700, Lee Jones wrote:
> > On Wed, 17 Sep 2014, Nishanth Menon wrote:
> > > ti,system-power-controller is more or less the standard way of
> > > indicating that the PMIC is the system wide power controller and hence
> > > may be used to switch off the system. Almost ALL TI PMIC drivers and
> > > many Maxim PMIC drivers follow the same style.
> > >
> > > So support 'ti,system-power-controller' in addition to the usual
> > > 'ti,use_poweroff' to indicate that the PMIC instance has control for
> > > switching off the system.
> > >
> > > Signed-off-by: Nishanth Menon <nm@ti.com>
> > > ---
> > >
> > > V2: picked up documentation suggestion from Sebastien
> >
> > It would be good to get Sebastian's Ack.
>
> Acked-By: Sebastian Reichel <sre@kernel.org>
>
> [...]
>
> > > +- ti,system-power-controller: This indicates that TWL4030 is the
> > > + power supply master of the system. With this flag, the chip will
> > > + initiates an ACTIVE-to-OFF or SLEEP-to-OFF transition when the
> > > + system poweroffs.
>
> One minor thing: While the documentation is updated you may want to
> fix the typo "will initiates" to "will initiate" (or just drop the
> "will").
Applied with Sebastian's Ack and I fixed this up too.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2014-09-17 21:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-17 12:34 [PATCH V2 0/2] mfd: twl4030-power: support ti,system-power-controller Nishanth Menon
2014-09-17 12:34 ` Nishanth Menon
2014-09-17 12:34 ` [PATCH V2 1/2] Documentation: devicetree: mfd: twl4030-power: Use the standard 'ti,system-power-controller' to mark power control Nishanth Menon
2014-09-17 12:34 ` Nishanth Menon
2014-09-17 15:44 ` Lee Jones
2014-09-17 16:55 ` Sebastian Reichel
2014-09-17 16:55 ` Sebastian Reichel
2014-09-17 17:01 ` Nishanth Menon
2014-09-17 17:01 ` Nishanth Menon
2014-09-17 21:39 ` Lee Jones [this message]
2014-09-17 12:34 ` [PATCH V2 2/2] mfd: twl4030-power: use 'ti,system-power-controller' as alternative way to support system power off Nishanth Menon
2014-09-17 12:34 ` Nishanth Menon
2014-09-17 21:39 ` Lee Jones
2014-09-17 21:39 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140917213958.GU30918@lee--X1 \
--to=lee.jones@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
--cc=sameo@linux.intel.com \
--cc=sre@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.