Re: [PATCH v7 5/7] ASoC: Intel: mrfld: add the DSP DAPM widgets

From: Vinod Koul <vinod.koul@intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, Lars-Peter Clausen <lars@metafoo.de>,
	"Subhransu S. Prusty" <subhransu.s.prusty@intel.com>,
	lgirdwood@gmail.com
Subject: Re: [PATCH v7 5/7] ASoC: Intel: mrfld: add the DSP DAPM widgets
Date: Mon, 6 Oct 2014 08:10:10 +0530	[thread overview]
Message-ID: <20141006024010.GQ1638@intel.com> (raw)
In-Reply-To: <20141002181228.GA4273@sirena.org.uk>

[-- Attachment #1.1: Type: text/plain, Size: 1132 bytes --]

On Thu, Oct 02, 2014 at 07:12:28PM +0100, Mark Brown wrote:
> On Fri, Sep 19, 2014 at 04:46:06PM +0530, Subhransu S. Prusty wrote:
> 
> > +#define SST_MMX_DECLARE_MIX_CONTROLS(kctl_name)			\
> > +	static const struct snd_kcontrol_new kctl_name[] = {			\
> > +		SOC_DAPM_SINGLE("media0_in", SND_SOC_NOPM, SST_IP_MEDIA0, 1, 0),	\
> > +		SOC_DAPM_SINGLE("media1_in", SND_SOC_NOPM, SST_IP_MEDIA1, 1, 0),	\
> > +		SOC_DAPM_SINGLE("media2_in", SND_SOC_NOPM, SST_IP_MEDIA2, 1, 0),	\
> > +		SOC_DAPM_SINGLE("media3_in", SND_SOC_NOPM, SST_IP_MEDIA3, 1, 0),	\
> > +	}
> 
> These should be Switch controls?
Yup I will fix this one.

> 
> > +	snd_soc_dapm_new_controls(dapm, sst_dapm_widgets,
> > +			ARRAY_SIZE(sst_dapm_widgets));
> > +	snd_soc_dapm_add_routes(dapm, intercon,
> > +			ARRAY_SIZE(intercon));
> > +	snd_soc_dapm_new_widgets(dapm->card);
> 
> We should be able to do this from the component but we can't yet...
We can convert once ready :)

I still have lots of stuff to do once this series is in. We also need to
enable dynamic firmware here once liam upstreams basic support :)

Thanks
-- 
~Vinod

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]