All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eryu Guan <eguan@redhat.com>
To: Wang Shilong <wangshilong1991@gmail.com>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH] xfstests,shared/032: fix fsck failure
Date: Thu, 9 Oct 2014 23:58:17 +0800	[thread overview]
Message-ID: <20141009155817.GI13912@dhcp-13-216.nay.redhat.com> (raw)
In-Reply-To: <1412895285-10544-1-git-send-email-wangshilong1991@gmail.com>

On Thu, Oct 09, 2014 at 06:54:45PM -0400, Wang Shilong wrote:
> while running ./check tests/shared/032, it outputs something like:
> 
> FSTYP         -- btrfs
> PLATFORM      -- Linux/x86_64 vm01 3.17.0-rc5+
> MKFS_OPTIONS  -- /dev/sdc
> MOUNT_OPTIONS -- /dev/sdc /mnt/scratch
> 
> shared/032 2s ... 2s
> _check_btrfs_filesystem: filesystem on /dev/sdc is inconsistent (see /root/xfstests-dev/results//shared/032.full)
> Ran: shared/032
> Passed all 1 tests
> 
> This is because xfstests will run fsck after each unit test,
> for tests/shared/032, we have reformated SCRATCH_DEV to other fs,
> so to make fsck happy later, let's fomrat fs here.
> 
> Signed-off-by: Wang Shilong <wangshilong1991@gmail.com>
> ---
>  tests/shared/032 | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/tests/shared/032 b/tests/shared/032
> index 7835e30..7a1a242 100755
> --- a/tests/shared/032
> +++ b/tests/shared/032
> @@ -91,6 +91,9 @@ do
>  	fi
>  done
>  
> +# make fsck happy later.
> +_scratch_mkfs > /dev/null 2>&1
> +

_require_scratch => _require_scratch_nocheck may be the right way to
go, just like 5d0153d does

5d0153d btrfs: use _nocheck for btrfs/011 and btrfs/012

Thanks,
Eryu
>  # success, all done
>  status=0
>  exit
> -- 
> 1.8.3.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe fstests" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2014-10-09 15:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-09 22:54 [PATCH] xfstests,shared/032: fix fsck failure Wang Shilong
2014-10-09 15:58 ` Eryu Guan [this message]
2014-10-09 16:15   ` Wang Shilong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141009155817.GI13912@dhcp-13-216.nay.redhat.com \
    --to=eguan@redhat.com \
    --cc=fstests@vger.kernel.org \
    --cc=wangshilong1991@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.