From: David Sterba <dsterba@suse.cz>
To: Zach Brown <zab@zabbo.net>
Cc: linux-btrfs@vger.kernel.org, David Sterba <dsterba@suse.cz>
Subject: Re: [PATCH 4/4] btrfs-progs: fix csum root copy-n-paste error
Date: Thu, 16 Oct 2014 12:55:30 +0200 [thread overview]
Message-ID: <20141016105530.GB22943@twin.jikos.cz> (raw)
In-Reply-To: <1413414861-28097-5-git-send-email-zab@zabbo.net>
On Wed, Oct 15, 2014 at 04:14:21PM -0700, Zach Brown wrote:
> btrfs_setup_all_roots() had some copy and pasted code for trying to
> setup a root and then creating a blank node if that failed. The copy
> for the csum_root created the blank node in the extent_root.
The cleanup is good, though I don't see the bug there. Although the passed root
is extent_root in both cases, it's only used to reach the
fs_info->extent_cache:
131 struct extent_buffer *btrfs_find_create_tree_block(struct btrfs_root *root,
132 u64 bytenr, u32 blocksize)
133 {
134 return alloc_extent_buffer(&root->fs_info->extent_cache, bytenr,
135 blocksize);
136 }
next prev parent reply other threads:[~2014-10-16 10:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-15 23:14 [PATCH 0/4] some btrfs-progs coverity fixes Zach Brown
2014-10-15 23:14 ` [PATCH 1/4] btrfs-progs: check sscanf return code Zach Brown
2014-10-15 23:14 ` [PATCH 2/4] btrfs-progs: check read extent errors when mapping Zach Brown
2014-10-15 23:14 ` [PATCH 3/4] btrfs-progs: fix show super unknown flag output Zach Brown
2014-10-15 23:14 ` [PATCH 4/4] btrfs-progs: fix csum root copy-n-paste error Zach Brown
2014-10-16 10:55 ` David Sterba [this message]
2014-10-16 11:46 ` [PATCH 0/4] some btrfs-progs coverity fixes David Sterba
2014-10-16 13:33 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141016105530.GB22943@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=zab@zabbo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.