From: Dave Chinner <david@fromorbit.com>
To: Theodore Ts'o <tytso@mit.edu>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH] common: suppress "Broken pipe" errors
Date: Thu, 11 Dec 2014 15:13:23 +1100 [thread overview]
Message-ID: <20141211041323.GF24183@dastard> (raw)
In-Reply-To: <1418264718-31198-1-git-send-email-tytso@mit.edu>
On Wed, Dec 10, 2014 at 09:25:18PM -0500, Theodore Ts'o wrote:
> It's possible based on a race conditions (and possibly the version of
> coreutils which supplies /usr/bin/yes) that commands of the form:
>
> yes | $MKFS_PROG ...
>
> will end up causing the following failure:
What race conditions?
> shared/298 16s ... [23:49:03] [23:49:19] - output mismatch (see /results/results-4k/shared/298.out.bad)
> --- tests/shared/298.out 2014-10-31 10:13:04.000000000 -0400
> +++ /results/results-4k/shared/298.out.bad 2014-11-29 23:49:19.118138099 -0500
> @@ -1,4 +1,6 @@
> QA output created by 298
> +yes: standard output: Broken pipe
> +yes: write error
But thats indicative that something failed and you need to analyse
the reason, yes? So AFAICT this is deisred behaviour, and hiding the
error will actually hide other failures, right?
> Generating garbage on loop...done.
> Running fstrim...done.
> Detecting interesting holes in image...done.
> ...
> (Run 'diff -u tests/shared/298.out /results/results-4k/shared/298.out.bad' to see the entire diff)
>
> The simplest way to fix this is to redirect the stderr of the yes
> command to /dev/null.
I'd highly recommend you add ext4 specific mkfs branches so you can
use the non-interactive/force mkfs flags so that "yes |" is not
necessary for your (and everyone elses ext4) test environments.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2014-12-11 4:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-11 2:25 [PATCH] common: suppress "Broken pipe" errors Theodore Ts'o
2014-12-11 4:13 ` Dave Chinner [this message]
2014-12-11 12:24 ` Theodore Ts'o
2014-12-11 23:30 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141211041323.GF24183@dastard \
--to=david@fromorbit.com \
--cc=fstests@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.