From: David Sterba <dsterba@suse.cz>
To: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: Chris Mason <clm@fb.com>, Josef Bacik <jbacik@fb.com>,
linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] btrfs: transaction: Remove unused function
Date: Wed, 14 Jan 2015 01:06:22 +0100 [thread overview]
Message-ID: <20150114000622.GO3685@twin.jikos.cz> (raw)
In-Reply-To: <1421175246-6448-1-git-send-email-rickard_strandqvist@spectrumdigital.se>
On Tue, Jan 13, 2015 at 07:54:06PM +0100, Rickard Strandqvist wrote:
> Remove the function btrfs_start_transaction_lflush() that is not used anywhere.
>
> This was partially found by using a static code analysis program called cppcheck.
http://thread.gmane.org/gmane.comp.file-systems.btrfs/27536
and this is my reply to 2nd attempt to remove the function:
"> btrfs_start_transaction_lflush()
Transcaction API, removing the func does not make sense without removing
BTRFS_RESERVE_FLUSH_LIMIT at the same time.
"
prev parent reply other threads:[~2015-01-14 0:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-13 18:54 [PATCH] btrfs: transaction: Remove unused function Rickard Strandqvist
2015-01-14 0:06 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150114000622.GO3685@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=clm@fb.com \
--cc=jbacik@fb.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rickard_strandqvist@spectrumdigital.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.