From: Mark Brown <broonie@kernel.org>
To: yang.a.fang@intel.com
Cc: alsa-devel@alsa-project.org, denny.iriawan@intel.com,
harshapriya.n@intel.com, praveen.k.jain@intel.com,
lgirdwood@gmail.com, kevin.strasser@intel.com,
vinod.koul@intel.com, mengdong.lin@intel.com
Subject: Re: [PATCH 1/2] ASoC: Intel:Add Cherrytrail & Braswell machine driver cht_bsw_rt5645
Date: Mon, 2 Feb 2015 19:05:21 +0000 [thread overview]
Message-ID: <20150202190521.GZ21293@sirena.org.uk> (raw)
In-Reply-To: <1422746560-91398-1-git-send-email-yang.a.fang@intel.com>
[-- Attachment #1.1: Type: text/plain, Size: 416 bytes --]
On Sat, Jan 31, 2015 at 03:22:39PM -0800, yang.a.fang@intel.com wrote:
> + /* Select clk_i2s1_asrc as ASRC clock source */
> + snd_soc_write(codec, RT5645_ASRC_2, 0x1111);
We should have an interface for doing this from the CODEC driver rather
than just randomly writing directly to registers - that way we don't
have something else working behind the back of the CODEC driver and
potentially interfering with it.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2015-02-02 19:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-31 23:22 [PATCH 1/2] ASoC: Intel:Add Cherrytrail & Braswell machine driver cht_bsw_rt5645 yang.a.fang
2015-01-31 23:22 ` [PATCH 2/2] ASoC: Intel:Add support rt5645 in sst driver yang.a.fang
2015-02-02 19:05 ` Mark Brown
2015-02-02 19:05 ` Mark Brown [this message]
2015-02-03 19:25 ` [PATCH v2 1/2] ASoC: rt5645: add API to select ASRC clock source yang.a.fang
2015-02-03 19:25 ` [PATCH v2 2/2] ASoC: Intel:Add Cherrytrail & Braswell machine driver cht_bsw_rt5645 yang.a.fang
2015-02-03 19:49 ` Vinod Koul
2015-02-03 20:03 ` [PATCH v3 1/2] ASoC: rt5645: add API to select ASRC clock source yang.a.fang
2015-02-03 20:03 ` [PATCH v3 2/2] ASoC: Intel:Add Cherrytrail & Braswell machine driver cht_bsw_rt5645 yang.a.fang
2015-02-04 1:29 ` Vinod Koul
2015-02-04 20:31 ` [PATCH v3 1/2] ASoC: rt5645: add API to select ASRC clock source Mark Brown
2015-02-05 2:19 ` [PATCH v4 " yang.a.fang
2015-02-05 2:19 ` [PATCH v4 2/2] ASoC: Intel:Add Cherrytrail & Braswell machine driver cht_bsw_rt5645 yang.a.fang
2015-02-05 18:10 ` [PATCH v4 1/2] ASoC: rt5645: add API to select ASRC clock source Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150202190521.GZ21293@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=denny.iriawan@intel.com \
--cc=harshapriya.n@intel.com \
--cc=kevin.strasser@intel.com \
--cc=lgirdwood@gmail.com \
--cc=mengdong.lin@intel.com \
--cc=praveen.k.jain@intel.com \
--cc=vinod.koul@intel.com \
--cc=yang.a.fang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.