All of lore.kernel.org
 help / color / mirror / Atom feed
From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: sunxi: Have ARCH_SUNXI select RESET_CONTROLLER for clock driver usage
Date: Mon, 23 Feb 2015 10:45:44 +0100	[thread overview]
Message-ID: <20150223094544.GC25269@lukather> (raw)
In-Reply-To: <1423477400-30520-1-git-send-email-wens@csie.org>

On Mon, Feb 09, 2015 at 06:23:20PM +0800, Chen-Yu Tsai wrote:
> As the sunxi usb clocks all contain a reset controller, it is not
> possible to build the sunxi clock driver without RESET_CONTROLLER
> enabled. Doing so results in an undefined symbol error:
> 
>     drivers/built-in.o: In function `sunxi_gates_clk_setup':
>     linux/drivers/clk/sunxi/clk-sunxi.c:1071: undefined reference to
> 	`reset_controller_register'
> 
> This is possible if building a minimal kernel without PHY_SUN4I_USB.
> 
> The dependency issue is made visible at compile time instead of
> link time by the new A80 mmc clocks, which also use a reset control
> itself.
> 
> This patch makes ARCH_SUNXI select ARCH_HAS_RESET_CONTROLLER and
> RESET_CONTROLLER.
> 
> Reported-by: Lourens Rozema <ik@lourensrozema.nl>
> Fixes: 559482d1f950 ARM: sunxi: Split the various SoCs support in Kconfig
> Cc: <stable@vger.kernel.org> # 3.16+
> Signed-off-by: Chen-Yu Tsai <wens@csie.org>

Applied with Arnd Acked-by.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150223/992ecf70/attachment.sig>

      reply	other threads:[~2015-02-23  9:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-09 10:23 [PATCH] ARM: sunxi: Have ARCH_SUNXI select RESET_CONTROLLER for clock driver usage Chen-Yu Tsai
2015-02-23  9:45 ` Maxime Ripard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150223094544.GC25269@lukather \
    --to=maxime.ripard@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.