From: Daniel Vetter <daniel@ffwll.ch>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 0/4] drm: constify all helper_private/func pointers
Date: Wed, 11 Mar 2015 08:33:45 +0100 [thread overview]
Message-ID: <20150311073345.GX3800@phenom.ffwll.local> (raw)
In-Reply-To: <20150310153435.GH11371@intel.com>
On Tue, Mar 10, 2015 at 05:34:35PM +0200, Ville Syrjälä wrote:
> On Tue, Mar 10, 2015 at 05:14:58PM +0200, Jani Nikula wrote:
> > On Tue, 10 Mar 2015, ville.syrjala@linux.intel.com wrote:
> > > Make the helper function pointer structs const to make it clear they
> > > should not be modified.
> >
> > So why not fix this once and for all? See the following patches.
>
> Why not indeed. I was being lazy and only hit the ones that caught my
> eye while crawling through the atomic helper stuff.
Well I pulled in your patch to drm-misc. Sounds like Jani still needs to
fine-tune his cocci.
-Daniel
>
> >
> > This was quick cocci, can be split by driver too if so desired.
> >
> > BR,
> > Jani.
> >
> >
> > Jani Nikula (4):
> > drm: constify all struct drm_encoder_helper_funcs pointers
> > drm: constify all struct drm_connector_helper_funcs pointers
> > drm: constify all struct drm_crtc_helper_funcs pointers
> > drm: make encoder/connector/crtc helper_private a const pointer
> >
> > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 4 ++--
> > drivers/gpu/drm/drm_atomic_helper.c | 24 ++++++++++++------------
> > drivers/gpu/drm/drm_crtc_helper.c | 24 ++++++++++++------------
> > drivers/gpu/drm/drm_fb_helper.c | 8 ++++----
> > drivers/gpu/drm/drm_plane_helper.c | 2 +-
> > drivers/gpu/drm/drm_probe_helper.c | 2 +-
> > drivers/gpu/drm/exynos/exynos_hdmi.c | 2 +-
> > drivers/gpu/drm/gma500/cdv_intel_display.c | 2 +-
> > drivers/gpu/drm/gma500/cdv_intel_hdmi.c | 2 +-
> > drivers/gpu/drm/gma500/cdv_intel_lvds.c | 2 +-
> > drivers/gpu/drm/gma500/gma_display.c | 10 +++++-----
> > drivers/gpu/drm/gma500/mdfld_dsi_output.c | 2 +-
> > drivers/gpu/drm/gma500/mdfld_intel_display.c | 2 +-
> > drivers/gpu/drm/gma500/oaktrail_crtc.c | 2 +-
> > drivers/gpu/drm/gma500/oaktrail_hdmi.c | 2 +-
> > drivers/gpu/drm/gma500/psb_intel_display.c | 2 +-
> > drivers/gpu/drm/gma500/psb_intel_lvds.c | 2 +-
> > drivers/gpu/drm/mgag200/mgag200_mode.c | 2 +-
> > drivers/gpu/drm/nouveau/dispnv04/crtc.c | 4 ++--
> > drivers/gpu/drm/nouveau/dispnv04/dac.c | 6 +++---
> > drivers/gpu/drm/nouveau/dispnv04/dfp.c | 6 +++---
> > drivers/gpu/drm/nouveau/dispnv04/disp.c | 6 +++---
> > drivers/gpu/drm/nouveau/dispnv04/tvnv04.c | 4 ++--
> > drivers/gpu/drm/nouveau/dispnv04/tvnv17.c | 4 ++--
> > drivers/gpu/drm/nouveau/nouveau_connector.c | 4 ++--
> > drivers/gpu/drm/qxl/qxl_drv.c | 2 +-
> > drivers/gpu/drm/radeon/radeon_connectors.c | 16 ++++++++--------
> > drivers/gpu/drm/radeon/radeon_legacy_encoders.c | 2 +-
> > include/drm/drm_crtc.h | 6 +++---
> > include/drm/drm_crtc_helper.h | 6 +++---
> > 30 files changed, 81 insertions(+), 81 deletions(-)
> >
> > --
> > 2.1.4
>
> --
> Ville Syrjälä
> Intel OTC
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2015-03-11 7:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-10 12:35 [PATCH] drm/atomic: Constify a bunch of functions pointer structs ville.syrjala
2015-03-10 15:14 ` [PATCH 0/4] drm: constify all helper_private/func pointers Jani Nikula
2015-03-10 15:14 ` [PATCH 1/4] drm: constify all struct drm_encoder_helper_funcs pointers Jani Nikula
2015-03-10 15:19 ` Jani Nikula
2015-03-10 15:15 ` [PATCH 2/4] drm: constify all struct drm_connector_helper_funcs pointers Jani Nikula
2015-03-10 15:15 ` [PATCH 3/4] drm: constify all struct drm_crtc_helper_funcs pointers Jani Nikula
2015-03-10 15:15 ` [PATCH 4/4] drm: make encoder/connector/crtc helper_private a const pointer Jani Nikula
2015-03-10 15:34 ` [PATCH 0/4] drm: constify all helper_private/func pointers Ville Syrjälä
2015-03-11 7:33 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150311073345.GX3800@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.