From: Taesoo Kim <taesoo@gatech.edu>
To: Christoph Hellwig <hch@infradead.org>
Cc: Taesoo Kim <tsgatesv@gmail.com>,
trond.myklebust@primarydata.com, anna.schumaker@netapp.com,
linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org,
changwoo@gatech.edu, sanidhya@gatech.edu, blee@gatech.edu,
csong84@gatech.edu, Byoungyoung Lee <lifeasageek@gmail.com>
Subject: Re: [PATCH] NFS: fix potential NULL deref in nfs_closedir()
Date: Sat, 21 Mar 2015 14:47:32 -0400 [thread overview]
Message-ID: <20150321184732.GA5170@taesoo.org> (raw)
In-Reply-To: <20150321180154.GA4916@infradead.org>
Ops. After reading nfs code, we also find out that nfs_opendir()
always allocates ctx obj (for private_data), unlike other fs allocate
private_data right before seeking dentries.
Sorry for the false alarm.
Taesoo
On 03/21/15 at 11:01am, Christoph Hellwig wrote:
> On Sat, Mar 21, 2015 at 12:21:18AM -0400, Taesoo Kim wrote:
> > From: Byoungyoung Lee <lifeasageek@gmail.com>
> >
> > When filp->private_data is NULL, put_nfs_open_dir_context()
> > deferences its pointer (fi->list, fi->cred), similar to what
> > other file systems handle '.release' api (9p, cifs, btrfs,
> > ext4, ocfs2).
>
> Why woud filp->private_data ever be NULL here?
prev parent reply other threads:[~2015-03-21 18:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-21 4:21 [PATCH] NFS: fix potential NULL deref in nfs_closedir() Taesoo Kim
2015-03-21 18:01 ` Christoph Hellwig
2015-03-21 18:47 ` Taesoo Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150321184732.GA5170@taesoo.org \
--to=taesoo@gatech.edu \
--cc=anna.schumaker@netapp.com \
--cc=blee@gatech.edu \
--cc=changwoo@gatech.edu \
--cc=csong84@gatech.edu \
--cc=hch@infradead.org \
--cc=lifeasageek@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=sanidhya@gatech.edu \
--cc=trond.myklebust@primarydata.com \
--cc=tsgatesv@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.