All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Boyd <sboyd@codeaurora.org>
To: Georgi Djakov <georgi.djakov@linaro.org>
Cc: mturquette@linaro.org, galak@codeaurora.org,
	linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v3 2/2] clk: qcom: Add MSM8916 Global Clock Controller support
Date: Mon, 23 Mar 2015 15:57:38 -0700	[thread overview]
Message-ID: <20150323225738.GA17476@codeaurora.org> (raw)
In-Reply-To: <1426687702-26216-3-git-send-email-georgi.djakov@linaro.org>

On 03/18, Georgi Djakov wrote:
> +
> +enum {
> +	P_XO,
> +	P_GPLL0,
> +	P_GPLL0_AUX,
> +	P_BIMC,
> +	P_GPLL1,
> +	P_GPLL1_AUX,
> +	P_GPLL2,
> +	P_GPLL2_AUX,
> +	P_SLEEP_CLK,
> +	P_DSI0_PHYPLL_BYTE,
> +	P_DSI0_PHYPLL_DSI,
> +};
> +
> +static const struct parent_map gcc_xo_gpll0_map[] = {
> +	{ P_XO, 0 },
> +	{ P_GPLL0, 1 },
> +	{ }

This doesn't have the updated tables. I fixed it up locally and
applied it.

diff --git a/drivers/clk/qcom/gcc-msm8916.c b/drivers/clk/qcom/gcc-msm8916.c
index c961f0dfdd2a..d3458474eb3a 100644
--- a/drivers/clk/qcom/gcc-msm8916.c
+++ b/drivers/clk/qcom/gcc-msm8916.c
@@ -49,7 +49,6 @@ enum {
 static const struct parent_map gcc_xo_gpll0_map[] = {
 	{ P_XO, 0 },
 	{ P_GPLL0, 1 },
-	{ }
 };
 
 static const char *gcc_xo_gpll0[] = {
@@ -61,7 +60,6 @@ static const struct parent_map gcc_xo_gpll0_bimc_map[] = {
 	{ P_XO, 0 },
 	{ P_GPLL0, 1 },
 	{ P_BIMC, 2 },
-	{ }
 };
 
 static const char *gcc_xo_gpll0_bimc[] = {
@@ -75,7 +73,6 @@ static const struct parent_map gcc_xo_gpll0a_gpll1_gpll2a_map[] = {
 	{ P_GPLL0_AUX, 3 },
 	{ P_GPLL2_AUX, 2 },
 	{ P_GPLL1, 1 },
-	{ }
 };
 
 static const char *gcc_xo_gpll0a_gpll1_gpll2a[] = {
@@ -89,7 +86,6 @@ static const struct parent_map gcc_xo_gpll0_gpll2_map[] = {
 	{ P_XO, 0 },
 	{ P_GPLL0, 1 },
 	{ P_GPLL2, 2 },
-	{ }
 };
 
 static const char *gcc_xo_gpll0_gpll2[] = {
@@ -101,7 +97,6 @@ static const char *gcc_xo_gpll0_gpll2[] = {
 static const struct parent_map gcc_xo_gpll0a_map[] = {
 	{ P_XO, 0 },
 	{ P_GPLL0_AUX, 2 },
-	{ }
 };
 
 static const char *gcc_xo_gpll0a[] = {
@@ -114,7 +109,6 @@ static const struct parent_map gcc_xo_gpll0_gpll1a_sleep_map[] = {
 	{ P_GPLL0, 1 },
 	{ P_GPLL1_AUX, 2 },
 	{ P_SLEEP_CLK, 6 },
-	{ }
 };
 
 static const char *gcc_xo_gpll0_gpll1a_sleep[] = {
@@ -128,7 +122,6 @@ static const struct parent_map gcc_xo_gpll0_gpll1a_map[] = {
 	{ P_XO, 0 },
 	{ P_GPLL0, 1 },
 	{ P_GPLL1_AUX, 2 },
-	{ }
 };
 
 static const char *gcc_xo_gpll0_gpll1a[] = {
@@ -140,7 +133,6 @@ static const char *gcc_xo_gpll0_gpll1a[] = {
 static const struct parent_map gcc_xo_dsibyte_map[] = {
 	{ P_XO, 0, },
 	{ P_DSI0_PHYPLL_BYTE, 2 },
-	{ }
 };
 
 static const char *gcc_xo_dsibyte[] = {
@@ -152,7 +144,6 @@ static const struct parent_map gcc_xo_gpll0a_dsibyte_map[] = {
 	{ P_XO, 0 },
 	{ P_GPLL0_AUX, 2 },
 	{ P_DSI0_PHYPLL_BYTE, 1 },
-	{ }
 };
 
 static const char *gcc_xo_gpll0a_dsibyte[] = {
@@ -165,7 +156,6 @@ static const struct parent_map gcc_xo_gpll0_dsiphy_map[] = {
 	{ P_XO, 0 },
 	{ P_GPLL0, 1 },
 	{ P_DSI0_PHYPLL_DSI, 2 },
-	{ }
 };
 
 static const char *gcc_xo_gpll0_dsiphy[] = {
@@ -178,7 +168,6 @@ static const struct parent_map gcc_xo_gpll0a_dsiphy_map[] = {
 	{ P_XO, 0 },
 	{ P_GPLL0_AUX, 2 },
 	{ P_DSI0_PHYPLL_DSI, 1 },
-	{ }
 };
 
 static const char *gcc_xo_gpll0a_dsiphy[] = {
@@ -192,7 +181,6 @@ static const struct parent_map gcc_xo_gpll0a_gpll1_gpll2_map[] = {
 	{ P_GPLL0_AUX, 1 },
 	{ P_GPLL1, 3 },
 	{ P_GPLL2, 2 },
-	{ }
 };
 
 static const char *gcc_xo_gpll0a_gpll1_gpll2[] = {

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

      reply	other threads:[~2015-03-23 22:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-18 14:08 [PATCH v3 0/2] clk: qcom: Add MSM8916 Global Clock Controller support Georgi Djakov
2015-03-18 14:08 ` [PATCH v3 1/2] dt-bindings: Add #defines for MSM8916 clocks and resets Georgi Djakov
2015-03-23 23:34   ` Stephen Boyd
2015-03-18 14:08 ` [PATCH v3 2/2] clk: qcom: Add MSM8916 Global Clock Controller support Georgi Djakov
2015-03-23 22:57   ` Stephen Boyd [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150323225738.GA17476@codeaurora.org \
    --to=sboyd@codeaurora.org \
    --cc=galak@codeaurora.org \
    --cc=georgi.djakov@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.