From: David Miller <davem@davemloft.net>
To: varun@chelsio.com
Cc: netdev@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-rdma@vger.kernel.org, JBottomley@parallels.com,
roland@purestorage.com, leedom@chelsio.com, anish@chelsio.com,
hariprasad@chelsio.com, swise@opengridcomputing.com,
kxie@chelsio.com, praveenm@chelsio.com, kumaras@chelsio.com
Subject: Re: [PATCH net-next v2 3/4] cxgb4: add DDP support for FCoE target
Date: Mon, 13 Apr 2015 13:12:59 -0400 (EDT) [thread overview]
Message-ID: <20150413.131259.1507649278753208323.davem@davemloft.net> (raw)
In-Reply-To: <a8d335d453e84d5cf2ca7826e6de24eba96af253.1428930614.git.varun@chelsio.com>
From: Varun Prakash <varun@chelsio.com>
Date: Mon, 13 Apr 2015 19:34:25 +0530
> diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_fcoe.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_fcoe.c
> index 6c8a62e..f78d632 100644
> --- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_fcoe.c
> +++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_fcoe.c
...
> + */
> +static inline unsigned int pages2ppods(unsigned int pages)
> +{
> + return (pages + PPOD_PAGES - 1) / PPOD_PAGES +
Please do not ever use inline in foo.c file function definitions. Let
the compiler decide on it's own.
Thanks.
next prev parent reply other threads:[~2015-04-13 17:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-13 14:04 [PATCH net-next v2 0/4] cxgb4: add FCoE DDP and RSS Varun Prakash
2015-04-13 14:04 ` [PATCH net-next v2 1/4] cxgb4/iw_cxgb4/cxgb4i: remove duplicate definitions Varun Prakash
2015-04-13 16:38 ` Jason Gunthorpe
[not found] ` <20150413163808.GA17521-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2015-04-15 13:04 ` Varun Prakash
2015-04-15 13:04 ` Varun Prakash
2015-04-15 16:12 ` Jason Gunthorpe
[not found] ` <6358f849b5a1a3727879f4f2f5c855e3a5b95ab4.1428930614.git.varun-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>
2015-04-13 18:13 ` Steve Wise
2015-04-13 14:04 ` [PATCH net-next v2 2/4] cxgb4: add structure and macro definitions for FCoE DDP Varun Prakash
2015-04-13 14:04 ` [PATCH net-next v2 3/4] cxgb4: add DDP support for FCoE target Varun Prakash
2015-04-13 17:12 ` David Miller [this message]
2015-04-13 14:04 ` [PATCH net-next v2 4/4] cxgb4: enable RSS for FCoE frames Varun Prakash
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150413.131259.1507649278753208323.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=JBottomley@parallels.com \
--cc=anish@chelsio.com \
--cc=hariprasad@chelsio.com \
--cc=kumaras@chelsio.com \
--cc=kxie@chelsio.com \
--cc=leedom@chelsio.com \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=praveenm@chelsio.com \
--cc=roland@purestorage.com \
--cc=swise@opengridcomputing.com \
--cc=varun@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.