From: Christoph Hellwig <hch@infradead.org>
To: NeilBrown <neilb@suse.de>
Cc: Christoph Hellwig <hch@infradead.org>,
David Howells <dhowells@redhat.com>, Chris Mason <clm@fb.com>,
Al Viro <viro@ZenIV.linux.org.uk>, Josef Bacik <jbacik@fb.com>,
David Sterba <dsterba@suse.cz>,
linux-cachefs@vger.kernel.org, Dave Chinner <david@fromorbit.com>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 2/3] fscache/cachefiles: optionally use SEEK_DATA instead of ->bmap.
Date: Mon, 20 Apr 2015 02:45:39 -0700 [thread overview]
Message-ID: <20150420094539.GA12622@infradead.org> (raw)
In-Reply-To: <20150420162700.3e69c7db@notabene.brown>
On Mon, Apr 20, 2015 at 04:27:00PM +1000, NeilBrown wrote:
> A worthwhile goal, but I certainly wouldn't consider pursuing it until what I
> have submitted so far as been accepted - let's not reject "good" while
> waiting for "perfect".
It's still broken. You add conditional flag for the almost right
(almost because the flag in the filesystem type needs to go) while
leaving the broken option th default. So what you propose here is not
good, it's at best just as bad as the old version because you don't
remove broken code but add a lot more clutter at the same time.
next prev parent reply other threads:[~2015-04-20 9:45 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-20 5:27 [PATCH 0/3] Allow fscache to work on BTRFS NeilBrown
2015-04-20 5:27 ` [PATCH 1/3] cachefiles: perform test on s_blocksize when opening cache file NeilBrown
2015-04-20 5:27 ` [PATCH 2/3] fscache/cachefiles: optionally use SEEK_DATA instead of ->bmap NeilBrown
2015-04-20 6:08 ` Christoph Hellwig
2015-04-20 6:27 ` NeilBrown
2015-04-20 9:45 ` Christoph Hellwig [this message]
2015-04-21 23:06 ` NeilBrown
2015-04-20 5:27 ` [PATCH 3/3] btrfs: set FS_SUPPORTS_SEEK_HOLE flag NeilBrown
2015-04-20 19:48 ` Chris Mason
2015-04-20 8:47 ` David Howells
2015-04-20 9:33 ` NeilBrown
2015-04-20 9:46 ` David Howells
2015-04-20 9:48 ` Christoph Hellwig
2015-04-20 12:58 ` Al Viro
2015-04-21 8:43 ` Christoph Hellwig
2015-04-21 10:23 ` Hugh Dickins
2015-04-27 5:41 ` NeilBrown
2015-04-27 13:43 ` Christoph Hellwig
2015-04-20 11:21 ` [PATCH 2/3] fscache/cachefiles: optionally use SEEK_DATA instead of ->bmap David Howells
2015-04-20 15:59 ` [RFC][PATCH] cachefiles: Make better use of SEEK_DATA/SEEK_HOLE David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150420094539.GA12622@infradead.org \
--to=hch@infradead.org \
--cc=clm@fb.com \
--cc=david@fromorbit.com \
--cc=dhowells@redhat.com \
--cc=dsterba@suse.cz \
--cc=jbacik@fb.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-cachefs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.de \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.