All of lore.kernel.org
 help / color / mirror / Atom feed
From: Inha Song <ideal.song@samsung.com>
To: Kukjin Kim <kgene@kernel.org>
Cc: Anand Moon <linux.amoon@gmail.com>,
	Markus Reichl <m.reichl@fivetechno.de>,
	Sylwester Nawrocki <s.nawrocki@samsung.com>,
	broonie@kernel.org, Rob Herring <robh+dt@kernel.org>,
	Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@codeaurora.org>,
	alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
	"linux-samsung-soc@vger.kernel.org"
	<linux-samsung-soc@vger.kernel.org>,
	Chanwoo Choi <cw00.choi@samsung.com>
Subject: Re: [alsa-devel] [PATCH v2 RESEND] ARM: dts: Support audio on Exynos5422-odroidxu3 using simple-audio-card
Date: Wed, 06 May 2015 10:47:14 +0900	[thread overview]
Message-ID: <20150506104714.498f8da5@songinha-Samsung-DeskTop-System> (raw)
In-Reply-To: <CANAwSgS98n0kX8oBUk5Ehk1fwU4DA_DNuAqztp3LrOBcmrtAZw@mail.gmail.com>

Hi Kukjin,

Any comments about this patch?

Best Regards,
Inha Song.

On Fri, 10 Apr 2015 14:48:13 +0530
Anand Moon <linux.amoon@gmail.com> wrote:

> Hi Inha,
> 
> Tested-by: Anand Moon <linux.amoon@gmail.com>
> 
> -Anand Moon
> 
> On 10 April 2015 at 14:32, Markus Reichl <m.reichl@fivetechno.de> wrote:
> > Hi Inha,
> >
> > I have tested this on XU3 (Headphone output).
> >
> > Tested-by: Markus Reichl <m.reichl@fivetechno.de>
> >
> > Best Regards
> > --
> > Markus Reichl
> >
> > Am 10.04.2015 um 09:32 schrieb Inha Song:
> >> Add MAX98090 audio codec, I2S interface and the sound nodes to support
> >> audio on Exynos5422 SoC Based Odroid-XU3 board. Now we can support audio
> >> in Odroid-XU3 board using simple-audio-card DT binding.
> >>
> >> Signed-off-by: Inha Song <ideal.song@samsung.com>
> >> Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
> >> ---
> >>  arch/arm/boot/dts/exynos5420.dtsi          |  9 +++++
> >>  arch/arm/boot/dts/exynos5422-odroidxu3.dts | 59 ++++++++++++++++++++++++++++++
> >>  2 files changed, 68 insertions(+)
> >>
> >> diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
> >> index ac6f860..73886d6 100644
> >> --- a/arch/arm/boot/dts/exynos5420.dtsi
> >> +++ b/arch/arm/boot/dts/exynos5420.dtsi
> >> @@ -415,6 +415,9 @@
> >>                       <&clock_audss EXYNOS_I2S_BUS>,
> >>                       <&clock_audss EXYNOS_SCLK_I2S>;
> >>               clock-names = "iis", "i2s_opclk0", "i2s_opclk1";
> >> +             #clock-cells = <1>;
> >> +             clock-output-names = "i2s_cdclk0";
> >> +             #sound-dai-cells = <1>;
> >>               samsung,idma-addr = <0x03000000>;
> >>               pinctrl-names = "default";
> >>               pinctrl-0 = <&i2s0_bus>;
> >> @@ -429,6 +432,9 @@
> >>               dma-names = "tx", "rx";
> >>               clocks = <&clock CLK_I2S1>, <&clock CLK_SCLK_I2S1>;
> >>               clock-names = "iis", "i2s_opclk0";
> >> +             #clock-cells = <1>;
> >> +             clock-output-names = "i2s_cdclk1";
> >> +             #sound-dai-cells = <1>;
> >>               pinctrl-names = "default";
> >>               pinctrl-0 = <&i2s1_bus>;
> >>               status = "disabled";
> >> @@ -442,6 +448,9 @@
> >>               dma-names = "tx", "rx";
> >>               clocks = <&clock CLK_I2S2>, <&clock CLK_SCLK_I2S2>;
> >>               clock-names = "iis", "i2s_opclk0";
> >> +             #clock-cells = <1>;
> >> +             clock-output-names = "i2s_cdclk2";
> >> +             #sound-dai-cells = <1>;
> >>               pinctrl-names = "default";
> >>               pinctrl-0 = <&i2s2_bus>;
> >>               status = "disabled";
> >> diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
> >> index edc25cf..c038f0d 100644
> >> --- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
> >> +++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
> >> @@ -11,6 +11,7 @@
> >>  */
> >>
> >>  /dts-v1/;
> >> +#include <dt-bindings/sound/samsung-i2s.h>
> >>  #include "exynos5800.dtsi"
> >>
> >>  / {
> >> @@ -285,6 +286,64 @@
> >>       rtc@101E0000 {
> >>               status = "okay";
> >>       };
> >> +
> >> +     sound: sound {
> >> +             compatible = "simple-audio-card";
> >> +
> >> +             simple-audio-card,name = "Odroid-XU3";
> >> +             simple-audio-card,widgets =
> >> +                     "Headphone", "Headphone Jack",
> >> +                     "Speakers", "Speakers";
> >> +             simple-audio-card,routing =
> >> +                     "Headphone Jack", "HPL",
> >> +                     "Headphone Jack", "HPR",
> >> +                     "Headphone Jack", "MICBIAS",
> >> +                     "IN1", "Headphone Jack",
> >> +                     "Speakers", "SPKL",
> >> +                     "Speakers", "SPKR";
> >> +
> >> +             simple-audio-card,format = "i2s";
> >> +             simple-audio-card,bitclock-master = <&link0_codec>;
> >> +             simple-audio-card,frame-master = <&link0_codec>;
> >> +
> >> +             simple-audio-card,cpu {
> >> +                     sound-dai = <&i2s0 0>;
> >> +                     system-clock-frequency = <19200000>;
> >> +             };
> >> +
> >> +             link0_codec: simple-audio-card,codec {
> >> +                     sound-dai = <&max98090>;
> >> +                     clocks = <&i2s0 CLK_I2S_CDCLK>;
> >> +             };
> >> +     };
> >> +};
> >> +
> >> +&clock_audss {
> >> +     assigned-clocks = <&clock_audss EXYNOS_MOUT_AUDSS>,
> >> +                     <&clock_audss EXYNOS_MOUT_I2S>,
> >> +                     <&clock_audss EXYNOS_DOUT_AUD_BUS>;
> >> +     assigned-clock-parents = <&clock CLK_FIN_PLL>,
> >> +                     <&clock_audss EXYNOS_MOUT_AUDSS>;
> >> +     assigned-clock-rates = <0>,
> >> +                     <0>,
> >> +                     <19200000>;
> >> +};
> >> +
> >> +&hsi2c_5 {
> >> +     status = "okay";
> >> +     max98090: max98090@10 {
> >> +             compatible = "maxim,max98090";
> >> +             reg = <0x10>;
> >> +             interrupt-parent = <&gpx3>;
> >> +             interrupts = <2 0>;
> >> +             clocks = <&i2s0 CLK_I2S_CDCLK>;
> >> +             clock-names = "mclk";
> >> +             #sound-dai-cells = <0>;
> >> +     };
> >> +};
> >> +
> >> +&i2s0 {
> >> +     status = "okay";
> >>  };
> >>
> >>  &hdmi {
> >>
> >
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2015-05-06  1:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-10  7:32 [alsa-devel] [PATCH v2 RESEND] ARM: dts: Support audio on Exynos5422-odroidxu3 using simple-audio-card Inha Song
     [not found] ` <1428651178-18186-1-git-send-email-ideal.song-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2015-04-10  9:02   ` Markus Reichl
     [not found]     ` <552791A4.40203-SRyzfwRm/0rPTwkrwQOX7A@public.gmane.org>
2015-04-10  9:18       ` Anand Moon
2015-05-06  1:47         ` Inha Song [this message]
2015-05-06 13:23           ` Javier Martinez Canillas
2015-05-06 23:49             ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150506104714.498f8da5@songinha-Samsung-DeskTop-System \
    --to=ideal.song@samsung.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=cw00.choi@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=kgene@kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux.amoon@gmail.com \
    --cc=m.reichl@fivetechno.de \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=s.nawrocki@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.