Re: [PATCH v1] spi: spi-fsl-dspi: Enable TCF interrupt mode support

From: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Haikun Wang <haikun.wang-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
Cc: linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v1] spi: spi-fsl-dspi: Enable TCF interrupt mode support
Date: Wed, 13 May 2015 12:45:58 +0100	[thread overview]
Message-ID: <20150513114558.GL3066@sirena.org.uk> (raw)
In-Reply-To: <1431351698-44015-1-git-send-email-haikun.wang-KZfg59tc24xl57MIdRCFDg@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 932 bytes --]

On Mon, May 11, 2015 at 09:41:38PM +0800, Haikun Wang wrote:
> DSPI module has two optional interrupts when complete data transfer.
> One is EOQ interrupt, the other one is TCF interrupt.
> EOQ indicates a queue of data frame has been transmitted.
> TCF indicates a frame has been transmitted.
> This patch enable support TCF mode.
> User can select expected mode from dts node.
> 
> Signed-off-by: Haikun Wang <haikun.wang-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> ---
>  drivers/spi/spi-fsl-dspi.c | 175 +++++++++++++++++++++++++++++----------------
>  1 file changed, 112 insertions(+), 63 deletions(-)

This is adding a DT binding without documenting it, all DT bindings need
to be documented.  I'm also not clear why this is something the user
would want to be able to select from DT - what is platform specific
about this?  Shouldn't the driver just ensure that the most appropriate
interrupt mode is used?

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]