All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Sterba <dsterba@suse.cz>
To: Anand Jain <Anand.Jain@oracle.com>
Cc: dsterba@suse.cz, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 00/27 V5] provide framework so that sysfs attributs from the fs_devices can be added
Date: Wed, 20 May 2015 18:40:39 +0200	[thread overview]
Message-ID: <20150520164039.GK23255@twin.jikos.cz> (raw)
In-Reply-To: <55239094.2010109@oracle.com>

On Tue, Apr 07, 2015 at 04:08:52PM +0800, Anand Jain wrote:
>   Can I check if this patch set is lined up for the integration branch ?
>   Any comments ?

I've noticed that the proposal to add an extra directory to the seeding
uuid hasn't been implemented.

http://article.gmane.org/gmane.comp.file-systems.btrfs/43095

  "I'm thinking about a representation of the possible relations between
  the devices. Seems that the seeding hierarchy for one filesystem is
  always linear, so it's ok to represent it by the filesystem UUID chain.

  /sys/fs/btrfs/UUID1/UUID2/UUID3

  What I still find unsatisfying is lack of any explicit naming attached
  to the UUIDs. As we can use lots of types of UUID, saying that "if it
  looks like an uuid if the main filesystem directory in sysfs, then it's
  the seeding filesystem" is not the best we can come up with.

  I don't have a final idea, but at least

  /sys/fs/btrfs/UUID1/seeding/UUID2/seeding/UUID3

  would look more friendly to the user and also more accssible to
  scripting. We coud possibly add other files/dirs to the inserted
  directory."

I still think that the plain UUID1/UUID2/... naming scheme is not
acceptable. Yes it is redundant in some way but also more descriptive.

  parent reply	other threads:[~2015-05-20 16:40 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-20 10:01 [PATCH 00/27 V5] provide framework so that sysfs attributs from the fs_devices can be added Anand Jain
2015-03-20 10:01 ` [PATCH 01/27] export symbol kobject_move() Anand Jain
2015-03-20 10:01 ` [PATCH 02/27] Btrfs: sysfs: fix, btrfs_release_super_kobj() should to clean up the kobject data Anand Jain
2015-03-20 10:01 ` [PATCH 03/27] Btrfs: sysfs: fix, fs_info kobject_unregister has init_completion() twice Anand Jain
2015-03-20 10:01 ` [PATCH 04/27] Btrfs: sysfs: fix, undo sysfs device links Anand Jain
2015-03-20 10:01 ` [PATCH 05/27] Btrfs: sysfs: fix, kobject pointer clean up needed after kobject release Anand Jain
2015-03-20 10:01 ` [PATCH 06/27] Btrfc: sysfs: fix, check if device_dir_kobj is init before destroy Anand Jain
2015-03-20 10:01 ` [PATCH 07/27] Btrfs: sysfs: reorder the kobject creations Anand Jain
2015-03-20 10:01 ` [PATCH 08/27] Btrfs: sysfs: rename __btrfs_sysfs_remove_one to btrfs_sysfs_remove_fsid Anand Jain
2015-03-20 10:01 ` [PATCH 09/27] Btrfs: sysfs: introduce function btrfs_sysfs_add_fsid() to create sysfs fsid Anand Jain
2015-03-20 10:01 ` [PATCH 10/27] Btrfs: sysfs: let default_attrs be separate from the kset Anand Jain
2015-03-20 10:01 ` [PATCH 11/27] Btrfs: sysfs: separate device kobject and its attribute creation Anand Jain
2015-03-20 10:01 ` [PATCH 12/27] Btrfs: sysfs: move super_kobj and device_dir_kobj from fs_info to btrfs_fs_devices Anand Jain
2015-03-20 10:01 ` [PATCH 13/27] Btrfs: introduce btrfs_get_fs_uuids to get fs_uuids Anand Jain
2015-03-20 10:01 ` [PATCH 14/27] Btrfs: sysfs: add pointer to access fs_info from fs_devices Anand Jain
2015-03-20 10:01 ` [PATCH 15/27] Btrfs: sysfs: provide framework to remove all fsid sysfs kobject Anand Jain
2015-03-20 10:01 ` [PATCH 16/27] Btrfs: sysfs btrfs_kobj_add_device() pass fs_devices instead of fs_info Anand Jain
2015-03-20 10:01 ` [PATCH 17/27] Btrfs: sysfs btrfs_kobj_rm_device() " Anand Jain
2015-03-20 10:01 ` [PATCH 18/27] Btrfs: sysfs: make btrfs_sysfs_add_fsid() non static Anand Jain
2015-03-20 10:01 ` [PATCH 19/27] Btrfs: sysfs: make btrfs_sysfs_add_device() " Anand Jain
2015-03-20 10:01 ` [PATCH 20/27] Btrfs: sysfs: btrfs_sysfs_remove_fsid() make it " Anand Jain
2015-03-20 10:01 ` [PATCH 21/27] Btrfs: sysfs: separate kobject and attribute creation Anand Jain
2015-03-20 10:01 ` [PATCH 22/27] Btrfs: sysfs: add support to add parent for fsid Anand Jain
2015-03-20 10:01 ` [PATCH 23/27] Btrfs: sysfs: don't fail seeding for the sake of sysfs kobject issue Anand Jain
2015-03-20 10:01 ` [PATCH 24/27] Btrfs: free the stale device Anand Jain
2015-05-22 15:33   ` [PATCH v5.1 " Anand Jain
2015-05-27 11:34     ` David Sterba
2015-05-30 15:34       ` Anand Jain
2015-05-30 15:32   ` [PATCH v5.2 24/42] " Anand Jain
2015-06-17 13:10     ` [PATCH v5.3 24/27] " Anand Jain
2015-03-20 10:01 ` [PATCH 25/27] Btrfs: sysfs: add support to show replacing target in the sysfs Anand Jain
2015-03-20 10:01 ` [PATCH 26/27] Btrfs: sysfs: support seed devices in the sysfs layout Anand Jain
2015-03-20 10:01 ` [PATCH 27/27] Btrfs: create sys/fs/btrfs/fsid when scanned instead of when mounted Anand Jain
2015-04-07  8:08 ` [PATCH 00/27 V5] provide framework so that sysfs attributs from the fs_devices can be added Anand Jain
2015-05-05 13:51   ` David Sterba
2015-05-20 16:40   ` David Sterba [this message]
2015-05-21 14:48     ` Anand Jain
2015-05-21 15:14       ` David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150520164039.GK23255@twin.jikos.cz \
    --to=dsterba@suse.cz \
    --cc=Anand.Jain@oracle.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.