From: Mark Brown <broonie@kernel.org>
To: Jun Nie <jun.nie@linaro.org>
Cc: alsa-devel@alsa-project.org, shawn.guo@linaro.org,
wan.zhijun@zte.com.cn, lgirdwood@gmail.com,
zte-lt@lists.linaro.org
Subject: Re: [PATCH 1/2] ASoC: zx: Add ZTE zx296702 I2S DAI driver
Date: Fri, 22 May 2015 13:36:57 +0100 [thread overview]
Message-ID: <20150522123657.GS21391@sirena.org.uk> (raw)
In-Reply-To: <1432119972-6934-1-git-send-email-jun.nie@linaro.org>
[-- Attachment #1.1: Type: text/plain, Size: 438 bytes --]
On Wed, May 20, 2015 at 07:06:11PM +0800, Jun Nie wrote:
> Add ZTE zx296702 I2S DAI driver
This looks good but depends on the DMA driver and a couple of small
nits:
> +config ZX296702_I2S
> + bool "ZX296702 i2s"
I see no reason for this to be bool as opposed to a tristate - why not
let people build it as a module?
> + default:
> + dev_err(cpu_dai->dev, "Unknwon master/slave format\n");
The driver consistently misspells unknown.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2015-05-22 13:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-20 11:06 [PATCH 1/2] ASoC: zx: Add ZTE zx296702 I2S DAI driver Jun Nie
2015-05-20 11:06 ` [PATCH 2/2] dt: Add documentation for the ZTE I2S controller Jun Nie
2015-05-22 12:36 ` Mark Brown [this message]
2015-05-23 14:02 ` [PATCH 1/2] ASoC: zx: Add ZTE zx296702 I2S DAI driver Jun Nie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150522123657.GS21391@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=jun.nie@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=shawn.guo@linaro.org \
--cc=wan.zhijun@zte.com.cn \
--cc=zte-lt@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.