Re: [PATCH 8/8] drm/i915: protect FBC functions with FBC checks

From: Chris Wilson <chris@chris-wilson.co.uk>
To: Paulo Zanoni <przanoni@gmail.com>
Cc: intel-gfx@lists.freedesktop.org, Paulo Zanoni <paulo.r.zanoni@intel.com>
Subject: Re: [PATCH 8/8] drm/i915: protect FBC functions with FBC checks
Date: Fri, 3 Jul 2015 19:50:31 +0100	[thread overview]
Message-ID: <20150703185031.GX14231@nuc-i3427.alporthouse.com> (raw)
In-Reply-To: <1435948854-4943-1-git-send-email-przanoni@gmail.com>

On Fri, Jul 03, 2015 at 03:40:54PM -0300, Paulo Zanoni wrote:
> From: Paulo Zanoni <paulo.r.zanoni@intel.com>
> 
> Now all the functions called by other files check whether FBC has been
> initialized. This allows us to drop the checks on the static
> functions.
> 
> v2:
>  - s/HAS_FBC/dev_priv->display.enable_fbc/ everywhere but the init
>    function (Chris).
> 
> Suggested-by: Chris Wilson <chris@chris-wilson.co.uk>
> Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
> ---
>  drivers/gpu/drm/i915/intel_fbc.c | 27 ++++++++++++++++++---------
>  1 file changed, 18 insertions(+), 9 deletions(-)
> 
> 
> I'm not 100% sure this is what Chris was asking for v2, so please clarify if
> this is not what we want.

Does the trick for me,
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx