Re: [PATCH] drm/i915: storm detection documentation update

From: Daniel Vetter <daniel@ffwll.ch>
To: Sivakumar Thulasimani <sivakumar.thulasimani@intel.com>
Cc: jani.nikula@intel.com, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: storm detection documentation update
Date: Mon, 13 Jul 2015 11:22:42 +0200	[thread overview]
Message-ID: <20150713092242.GX3736@phenom.ffwll.local> (raw)
In-Reply-To: <1436511643-1586-1-git-send-email-sivakumar.thulasimani@intel.com>

On Fri, Jul 10, 2015 at 12:30:43PM +0530, Sivakumar Thulasimani wrote:
> From: "Thulasimani,Sivakumar" <sivakumar.thulasimani@intel.com>
> 
> Update the hotplug documentation to explain that hotplug storm
> is not expected for Display port panels and hence is not handled
> in current code.
> 
> v2: update the statements as recommended by Daniel
> 
> Signed-off-by: Sivakumar Thulasimani <sivakumar.thulasimani@intel.com>

Queued for -next, thanks for the patch.
-Daniel

> ---
>  drivers/gpu/drm/i915/intel_hotplug.c |    8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/intel_hotplug.c b/drivers/gpu/drm/i915/intel_hotplug.c
> index bac91a1..3c9171f 100644
> --- a/drivers/gpu/drm/i915/intel_hotplug.c
> +++ b/drivers/gpu/drm/i915/intel_hotplug.c
> @@ -66,6 +66,14 @@
>   * while before being re-enabled. The intention is to mitigate issues raising
>   * from broken hardware triggering massive amounts of interrupts and grinding
>   * the system to a halt.
> + *
> + * Current implementation expects that hotplug interrupt storm will not be
> + * seen when display port sink is connected, hence on platforms whose DP
> + * callback is handled by i915_digport_work_func reenabling of hpd is not
> + * performed (it was never expected to be disabled in the first place ;) )
> + * this is specific to DP sinks handled by this routine and any other display
> + * such as HDMI or DVI enabled on the same port will have proper logic since
> + * it will use i915_hotplug_work_func where this logic is handled.
>   */
>  
>  enum port intel_hpd_pin_to_port(enum hpd_pin pin)
> -- 
> 1.7.9.5
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx