From: Bjorn Helgaas <bhelgaas@google.com>
To: linux-pci@vger.kernel.org
Cc: "Mathias Nyman" <mathias.nyman@intel.com>,
x86@kernel.org, "Felipe Balbi" <balbi@ti.com>,
"Yu Zhao" <yu.zhao@intel.com>, "Huang Rui" <ray.huang@amd.com>,
"Krzysztof Hałasa" <khalasa@piap.pl>,
"Matthew Wilcox" <willy@linux.intel.com>,
"Jason Chang" <jason.chang@amd.com>
Subject: [PATCH v2 0/5] PCI: Fix class code usage
Date: Tue, 14 Jul 2015 14:34:27 -0500 [thread overview]
Message-ID: <20150714193153.13224.40528.stgit@bhelgaas-glaptop2.roam.corp.google.com> (raw)
PCI class code management is confusing. The pci_dev.class element contains
a three-byte value: base class/sub-class/interface.
The PCI_BASE_CLASS_* definitions are a single byte, i.e., dev->class >> 16.
The PCI_CLASS_* definitions are either two or three bytes, i.e., either
dev->class >> 8 or just dev->class.
We had several places where we used a two-byte PCI_CLASS_* definition but
forgot to shift it to the right place. These patches fix that for NCR
53c810, TI816X, and Intel USB devices.
As far as I can tell, reset_intel_generic_dev() never worked, so I just
removed it completely.
Changes from v1 to v2:
- Instead of trying to fix reset_intel_generic_dev(), drop it completely
---
Bjorn Helgaas (5):
PCI: Use PCI_CLASS_SERIAL_USB instead of bare number
PCI: Fix generic NCR 53c810 class code quirk
PCI: Fix TI816X class code quirk
PCI: Revert aeb30016fec3 ("PCI: add Intel USB specific reset method")
PCI: Shift PCI_CLASS_NOT_DEFINED consistently with other classes
arch/x86/pci/fixup.c | 13 ----------
drivers/pci/probe.c | 2 +-
drivers/pci/quirks.c | 65 +++++++++++++++++++-------------------------------
3 files changed, 26 insertions(+), 54 deletions(-)
next reply other threads:[~2015-07-14 19:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-14 19:34 Bjorn Helgaas [this message]
2015-07-14 19:34 ` [PATCH v2 1/5] PCI: Use PCI_CLASS_SERIAL_USB instead of bare number Bjorn Helgaas
2015-07-14 19:34 ` [PATCH v2 2/5] PCI: Fix generic NCR 53c810 class code quirk Bjorn Helgaas
2015-07-14 19:34 ` [PATCH v2 3/5] PCI: Fix TI816X " Bjorn Helgaas
2015-07-14 19:35 ` [PATCH v2 4/5] PCI: Revert aeb30016fec3 ("PCI: add Intel USB specific reset method") Bjorn Helgaas
2015-07-14 19:35 ` [PATCH v2 5/5] PCI: Shift PCI_CLASS_NOT_DEFINED consistently with other classes Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150714193153.13224.40528.stgit@bhelgaas-glaptop2.roam.corp.google.com \
--to=bhelgaas@google.com \
--cc=balbi@ti.com \
--cc=jason.chang@amd.com \
--cc=khalasa@piap.pl \
--cc=linux-pci@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=ray.huang@amd.com \
--cc=willy@linux.intel.com \
--cc=x86@kernel.org \
--cc=yu.zhao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.