From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Benjamin Gaignard <benjamin.gaignard@linaro.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
Xinwei Kong <kong.kongxinwei@hisilicon.com>,
"Liguozhu (Kenneth)" <liguozhu@hisilicon.com>
Subject: Re: [PATCH 1/1] drm/sti: fix master bind bug for using component
Date: Wed, 15 Jul 2015 11:42:43 +0100 [thread overview]
Message-ID: <20150715104243.GY7557@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <CA+M3ks7=6jdHXR5rfTEDnsEM=57769sNpD+=0c_6bm5Ce+6V=g@mail.gmail.com>
On Wed, Jul 15, 2015 at 12:19:01PM +0200, Benjamin Gaignard wrote:
> The build order in Makefile hasn't been change so the bug doesn't occur...
>
> In addition of taking care of not changing build order in Makefile,
> I would like to understand what is the expected behavior of component
> framework when
> master call component_bind_all() before any component_add() calls.
>
> Should component bind function be called in component_add() ?
> Is up to component to detect that master is already bounded ?
>
> Russell can you tell us what to do in this case ?
I don't follow, and you certainly should never get into the situation
you're alluding to (where the master is already bound but a component
is not.)
The way this should work is:
- master and components register themselves into the component helper
in a random order.
- when the master registers, it gives the component helper a set of
matches which it uses to determine which components are required.
- when the component helper determines that all components and the
master have been registered, it calls the master bind function.
- the master bind function is responsible for the classical subsystem
initialisation, calling component_bind_all() to cause the individual
components bind() method to be called.
So, you should never _ever_ be in the situation where initcall ordering
matters, or where the master is already bound but a component hasn't
registered.
--
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2015-07-15 10:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-14 9:28 [PATCH 1/1] drm/sti: fix master bind bug for using component Xinwei Kong
2015-07-15 10:19 ` Benjamin Gaignard
2015-07-15 10:42 ` Russell King - ARM Linux [this message]
2015-07-15 13:17 ` Benjamin Gaignard
2015-07-16 1:13 ` Xinwei Kong
2015-07-16 7:17 ` Benjamin Gaignard
2015-07-16 9:06 ` Xinwei Kong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150715104243.GY7557@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=benjamin.gaignard@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=kong.kongxinwei@hisilicon.com \
--cc=liguozhu@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.